Mercurial > vim
view src/testdir/popupbounce.vim @ 34596:5a8340e044f4 v9.1.0190
patch 9.1.0190: complete_info() returns wrong order of items
Commit: https://github.com/vim/vim/commit/8950bf7f8b85c1287d4e696965d88091fcc60594
Author: Girish Palya <girishji@gmail.com>
Date: Wed Mar 20 20:07:29 2024 +0100
patch 9.1.0190: complete_info() returns wrong order of items
Problem: complete_info() returns wrong order of items
(after v9.0.2018)
Solution: Revert Patch v9.0.2018
(Girish Palya)
bug fix: complete_info() gives wrong results
1) complete_info() reverses list of items during <c-p>
2) 'selected' item index is wrong during <c-p>
3) number of items returnd can be wrong
Solution:
- Decouple 'cp_number' from 'selected' index since they need not be
correlated
- Do not iterate the list backwards
- Add targeted tests
Regression introduced by https://github.com/vim/vim/commit/69fb5afb3bc9da24c2fb0eafb0027ba9c6502fc2
Following are unnecessary commits to patch problems from above:
https://github.com/vim/vim/commit/fef66301665027f1801a18d796f74584666f41ef
https://github.com/vim/vim/commit/daef8c74375141974d61b85199b383017644978c
All the tests from above commits are retained though.
fixes: #14204
closes: #14241
Signed-off-by: Girish Palya <girishji@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Wed, 20 Mar 2024 20:15:03 +0100 |
parents | 9606c0adc148 |
children |
line wrap: on
line source
" Use this script to measure the redrawing performance when a popup is being " displayed. Usage with gcc: " cd src " # Edit Makefile to uncomment PROFILE_CFLAGS and PROFILE_LIBS " make reconfig " ./vim --clean -S testdir/popupbounce.vim main.c " gprof vim gmon.out | vim - " using line continuation set nocp " don't switch screens when quitting, so we can read the frames/sec set t_te= let winid = popup_create(['line1', 'line2', 'line3', 'line4'], { \ 'line' : 1, \ 'col' : 1, \ 'zindex' : 101, \ }) redraw let start = reltime() let framecount = 0 let line = 1.0 let col = 1 let downwards = 1 let col_inc = 1 let initial_speed = 0.2 let speed = initial_speed let accel = 1.1 let time = 0.1 let countdown = 0 while 1 if downwards let speed += time * accel let line += speed else let speed -= time * accel let line -= speed endif if line + 3 >= &lines let downwards = 0 let speed = speed * 0.8 let line = &lines - 3 endif if !downwards && speed < 1.0 let downwards = 1 let speed = initial_speed if line + 4 > &lines && countdown == 0 let countdown = 50 endif endif let col += col_inc if col + 4 >= &columns let col_inc = -1 elseif col <= 1 let col_inc = 1 endif call popup_move(winid, {'line': float2nr(line), 'col': col}) redraw let framecount += 1 if countdown > 0 let countdown -= 1 if countdown == 0 break endif endif endwhile let elapsed = reltimefloat(reltime(start)) echomsg framecount .. ' frames in ' .. string(elapsed) .. ' seconds, ' .. string(framecount / elapsed) .. ' frames/sec' qa