patch 9.1.0190: complete_info() returns wrong order of items Commit: https://github.com/vim/vim/commit/8950bf7f8b85c1287d4e696965d88091fcc60594 Author: Girish Palya <girishji@gmail.com> Date: Wed Mar 20 20:07:29 2024 +0100 patch 9.1.0190: complete_info() returns wrong order of items Problem: complete_info() returns wrong order of items (after v9.0.2018) Solution: Revert Patch v9.0.2018 (Girish Palya) bug fix: complete_info() gives wrong results 1) complete_info() reverses list of items during <c-p> 2) 'selected' item index is wrong during <c-p> 3) number of items returnd can be wrong Solution: - Decouple 'cp_number' from 'selected' index since they need not be correlated - Do not iterate the list backwards - Add targeted tests Regression introduced by https://github.com/vim/vim/commit/69fb5afb3bc9da24c2fb0eafb0027ba9c6502fc2 Following are unnecessary commits to patch problems from above: https://github.com/vim/vim/commit/fef66301665027f1801a18d796f74584666f41ef https://github.com/vim/vim/commit/daef8c74375141974d61b85199b383017644978c All the tests from above commits are retained though. fixes: #14204 closes: #14241 Signed-off-by: Girish Palya <girishji@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>

|s+0&#ffffff0|o|m|e| |t|e|x|t| |a|t| |t|h|e| |t|o|p| @19||+1&&|s+0&&|o|m|e| |t|e|x|t| |a|t| |t|h|e| |t|o|p| @13
@2|o|n|e| |m|o|r|e| |t|e|x|t| @24||+1&&| +0&&@1|o|n|e| |m|o|r|e| |t|e|x|t| @18
@2|t|w|o| |m|o|r|e| |t|e|x|t| @24||+1&&| +0&&@1|t|w|o| |m|o|r|e| |t|e|x|t| @18
@2|t|h|r|e@1| |m|o|r|e| |t|e|x|t| @22||+1&&| +0&&@1|t|h|r|e@1| |m|o|r|e| |t|e|x|t| @16
@2>f|o|u|r| |m|o|r|e| |t|e|x|t| @23||+1&&| +0&&@1|f|o|u|r| |m|o|r|e| |t|e|x|t| @17
@40||+1&&| +0&&@33
|~+0#4040ff13&| @38||+1#0000000&|~+0#4040ff13&| @32
|~| @38||+1#0000000&|~+0#4040ff13&| @32
|[+3#0000000&|N|o| |N|a|m|e|]| |[|+|]| @8|5|,|3| @11|A|l@1| |[+1&&|N|o| |N|a|m|e|]| |[|+|]| @3|6|,|0|-|1| @8|A|l@1
| +0&&@74