Mercurial > vim
view src/proto/evalwindow.pro @ 34196:57b21d421cb2 v9.1.0048
patch 9.1.0048: Abort opening cmdwin if autocmds screw things up
Commit: https://github.com/vim/vim/commit/43b395ec2e7d24a067d7cb00109818b64da144a5
Author: Sean Dewar <seandewar@users.noreply.github.com>
Date: Wed Aug 16 16:17:31 2023 +0100
patch 9.1.0048: Abort opening cmdwin if autocmds screw things up
Problem: Autocmds triggered from opening the cmdwin (in win_split and
do_ecmd) can cause issues such as E199, as the current checks
are insufficient.
Solution: Commands executed from the cmdwin apply to the old curwin/buf,
so they should be kept in a "suspended" state; abort if
they've changed. Also abort if cmdwin/buf was tampered with,
and check that curwin is correct. Try to clean up the cmdwin
buffer (only if hidden and non-current to simplify things; the
same approach is used when closing cmdwin normally), and add a
beep. (Sean Dewar)
It'd be nice to also check that curwin was *really* created by win_split, as
autocommands can change curwin before it returns (so it can't be assumed to be
that of the split); for now, this means that the cmdwin may not be the botwin in
that case, which is probably OK.
closes: #12819
Signed-off-by: Sean Dewar <seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Tue, 23 Jan 2024 23:00:05 +0100 |
| parents | b94cdb5ef20e |
| children |
line wrap: on
line source
/* evalwindow.c */ win_T *win_id2wp(int id); win_T *win_id2wp_tp(int id, tabpage_T **tpp); void win_findbuf(typval_T *argvars, list_T *list); win_T *find_win_by_nr(typval_T *vp, tabpage_T *tp); win_T *find_win_by_nr_or_id(typval_T *vp); win_T *find_tabwin(typval_T *wvp, typval_T *tvp, tabpage_T **ptp); void f_gettabinfo(typval_T *argvars, typval_T *rettv); void f_getwininfo(typval_T *argvars, typval_T *rettv); void f_getwinpos(typval_T *argvars, typval_T *rettv); void f_getwinposx(typval_T *argvars, typval_T *rettv); void f_getwinposy(typval_T *argvars, typval_T *rettv); void f_tabpagenr(typval_T *argvars, typval_T *rettv); void f_tabpagewinnr(typval_T *argvars, typval_T *rettv); void f_win_execute(typval_T *argvars, typval_T *rettv); void f_win_findbuf(typval_T *argvars, typval_T *rettv); void f_win_getid(typval_T *argvars, typval_T *rettv); void f_win_gotoid(typval_T *argvars, typval_T *rettv); void f_win_id2tabwin(typval_T *argvars, typval_T *rettv); void f_win_id2win(typval_T *argvars, typval_T *rettv); void f_win_move_separator(typval_T *argvars, typval_T *rettv); void f_win_move_statusline(typval_T *argvars, typval_T *rettv); void f_win_screenpos(typval_T *argvars, typval_T *rettv); void f_win_splitmove(typval_T *argvars, typval_T *rettv); void f_win_gettype(typval_T *argvars, typval_T *rettv); void f_getcmdwintype(typval_T *argvars, typval_T *rettv); void f_winbufnr(typval_T *argvars, typval_T *rettv); void f_wincol(typval_T *argvars, typval_T *rettv); void f_winheight(typval_T *argvars, typval_T *rettv); void f_winlayout(typval_T *argvars, typval_T *rettv); void f_winline(typval_T *argvars, typval_T *rettv); void f_winnr(typval_T *argvars, typval_T *rettv); void f_winrestcmd(typval_T *argvars, typval_T *rettv); void f_winrestview(typval_T *argvars, typval_T *rettv); void f_winsaveview(typval_T *argvars, typval_T *rettv); void f_winwidth(typval_T *argvars, typval_T *rettv); int switch_win(switchwin_T *switchwin, win_T *win, tabpage_T *tp, int no_display); int switch_win_noblock(switchwin_T *switchwin, win_T *win, tabpage_T *tp, int no_display); void restore_win(switchwin_T *switchwin, int no_display); void restore_win_noblock(switchwin_T *switchwin, int no_display); /* vim: set ft=c : */