Mercurial > vim
view src/vimtutor @ 34627:5071d4c3ff2e v9.1.0202
patch 9.1.0202: leaking memory in add_user() on failure
Commit: https://github.com/vim/vim/commit/7a2f217988afa1c35b9c093a9d3477198ea250b9
Author: Christian Brabandt <cb@256bit.org>
Date: Sun Mar 24 09:50:03 2024 +0100
patch 9.1.0202: leaking memory in add_user() on failure
Problem: leaking memory in add_user() (LuMingYinDetect)
Solution: free user_copy pointer instead of the user ptr
add_user() is called with a user pointer and the user pointer comes
from these functions:
- return value from the getpwent() function (Unix).
- return value from the getpwnam() function (Unix).
- return value from the NetUserEnum() function (MS Windows).
For the first 2 callers, the man page for those functions directly says,
one should not free the returned pointer (since it comes from static
memory).
For the third caller (on MS Windows), the returned buffer is already
freed directly after calling the add_user() function in
NetApiBufferFree(), so this would lead to a double free().
This all indicates, the user ptr is wrongly freed in the add_user()
function and the intention was to free the user_copy pointer instead in
case of an error.
So let's just use that now.
fixes: #14250
closes: #14260
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Sun, 24 Mar 2024 10:00:09 +0100 |
parents | d4faa2c5211b |
children |
line wrap: on
line source
#!/bin/sh # Start Vim on a copy of the tutor file. # Usage: vimtutor [-g] [xx] # Where optional argument -g starts vimtutor in gvim (GUI) instead of vim. # and xx is a language code like "es" or "nl". # When an argument is given, it tries loading that tutor. # When this fails or no argument was given, it tries using 'v:lang' # When that also fails, it uses the English version. # Vim could be called "vim" or "vi". Also check for "vimN", for people who # have Vim installed with its version number. # We anticipate up to a future Vim 8.1 version :-). seq="vim vim81 vim80 vim8 vim74 vim73 vim72 vim71 vim70 vim7 vim6 vi" if test "$1" = "-g"; then # Try to use the GUI version of Vim if possible, it will fall back # on Vim if Gvim is not installed. seq="gvim gvim81 gvim80 gvim8 gvim74 gvim73 gvim72 gvim71 gvim70 gvim7 gvim6 $seq" shift fi xx=$1 export xx # We need a temp file for the copy. First try using a standard command. tmp="${TMPDIR-/tmp}" TUTORCOPY=`mktemp $tmp/tutorXXXXXX || tempfile -p tutor || echo none` # If the standard commands failed then create a directory to put the copy in. # That is a secure way to make a temp file. if test "$TUTORCOPY" = none; then tmpdir=$tmp/vimtutor$$ OLD_UMASK=`umask` umask 077 getout=no mkdir $tmpdir || getout=yes umask $OLD_UMASK if test $getout = yes; then echo "Could not create directory for tutor copy, exiting." exit 1 fi TUTORCOPY=$tmpdir/tutorcopy touch $TUTORCOPY TODELETE=$tmpdir else TODELETE=$TUTORCOPY fi export TUTORCOPY # remove the copy of the tutor on exit trap "rm -rf $TODELETE" 0 1 2 3 9 11 13 15 for i in $seq; do testvim=$(which $i 2>/dev/null) if test -f "$testvim"; then VIM=$i break fi done # When no Vim version was found fall back to "vim", you'll get an error message # below. if test -z "$VIM"; then VIM=vim fi # Use Vim to copy the tutor, it knows the value of $VIMRUNTIME # The script tutor.vim tells Vim which file to copy $VIM -f -u NONE -c 'so $VIMRUNTIME/tutor/tutor.vim' # Start vim without any .vimrc, set 'nocompatible' and 'showcmd' $VIM -f -u NONE -c "set nocp showcmd" "$TUTORCOPY"