Mercurial > vim
view src/testdir/test_fixeol.vim @ 35150:42f061099b39 v9.1.0404
patch 9.1.0404: [security] xxd: buffer-overflow with specific flags
Commit: https://github.com/vim/vim/commit/67797191e039196128c69ba1538ccaf2a4711323
Author: Lennard Hofmann <lennard.hofmann@web.de>
Date: Fri May 10 14:17:26 2024 +0200
patch 9.1.0404: [security] xxd: buffer-overflow with specific flags
Problem: [security] xxd: buffer-overflow with specific flags
Solution: Correctly calculate the required buffer space
(Lennard Hofmann)
xxd writes each output line into a global buffer before printing.
The maximum size of that buffer was not calculated correctly.
This command was crashing in AddressSanitizer:
$ xxd -Ralways -g1 -c256 -d -o 9223372036854775808 /etc/passwd
This prints a line of 6680 bytes but the buffer only had room for 6549 bytes.
If the output from "-b" was colored, the line could be even longer.
closes: #14738
Co-authored-by: K.Takata <kentkt@csc.jp>
Signed-off-by: Lennard Hofmann <lennard.hofmann@web.de>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Fri, 10 May 2024 14:45:03 +0200 |
parents | 92b1338023ee |
children |
line wrap: on
line source
" Tests for 'fixeol', 'eof' and 'eol' func Test_fixeol() " first write two test files – with and without trailing EOL " use Unix fileformat for consistency set ff=unix enew! call setline('.', 'with eol or eof') w! XXEol enew! set noeof noeol nofixeol call setline('.', 'without eol or eof') w! XXNoEol set eol eof fixeol bwipe XXEol XXNoEol " try editing files with 'fixeol' disabled e! XXEol normal ostays eol set nofixeol w! XXTestEol e! XXNoEol normal ostays without set nofixeol w! XXTestNoEol bwipe! XXEol XXNoEol XXTestEol XXTestNoEol set fixeol " Append "END" to each file so that we can see what the last written char " was. normal ggdGaEND w >>XXEol w >>XXNoEol w >>XXTestEol w >>XXTestNoEol call assert_equal(['with eol or eof', 'END'], readfile('XXEol')) call assert_equal(['without eol or eofEND'], readfile('XXNoEol')) call assert_equal(['with eol or eof', 'stays eol', 'END'], readfile('XXTestEol')) call assert_equal(['without eol or eof', 'stays withoutEND'], \ readfile('XXTestNoEol')) call delete('XXEol') call delete('XXNoEol') call delete('XXTestEol') call delete('XXTestNoEol') set ff& fixeol& eof& eol& enew! endfunc func Test_eof() let data = 0z68656c6c6f.0d0a.776f726c64 " "hello\r\nworld" " 1. Eol, Eof " read call writefile(data + 0z0d0a.1a, 'XXEolEof') e! XXEolEof call assert_equal(['hello', 'world'], getline(1, 2)) call assert_equal([1, 1], [&eol, &eof]) " write set fixeol w! call assert_equal(data + 0z0d0a, readblob('XXEolEof')) set nofixeol w! call assert_equal(data + 0z0d0a.1a, readblob('XXEolEof')) " 2. NoEol, Eof " read call writefile(data + 0z1a, 'XXNoEolEof') e! XXNoEolEof call assert_equal(['hello', 'world'], getline(1, 2)) call assert_equal([0, 1], [&eol, &eof]) " write set fixeol w! call assert_equal(data + 0z0d0a, readblob('XXNoEolEof')) set nofixeol w! call assert_equal(data + 0z1a, readblob('XXNoEolEof')) " 3. Eol, NoEof " read call writefile(data + 0z0d0a, 'XXEolNoEof') e! XXEolNoEof call assert_equal(['hello', 'world'], getline(1, 2)) call assert_equal([1, 0], [&eol, &eof]) " write set fixeol w! call assert_equal(data + 0z0d0a, readblob('XXEolNoEof')) set nofixeol w! call assert_equal(data + 0z0d0a, readblob('XXEolNoEof')) " 4. NoEol, NoEof " read call writefile(data, 'XXNoEolNoEof') e! XXNoEolNoEof call assert_equal(['hello', 'world'], getline(1, 2)) call assert_equal([0, 0], [&eol, &eof]) " write set fixeol w! call assert_equal(data + 0z0d0a, readblob('XXNoEolNoEof')) set nofixeol w! call assert_equal(data, readblob('XXNoEolNoEof')) call delete('XXEolEof') call delete('XXNoEolEof') call delete('XXEolNoEof') call delete('XXNoEolNoEof') set ff& fixeol& eof& eol& enew! endfunc " vim: shiftwidth=2 sts=2 expandtab