Mercurial > vim
view src/testdir/test_preview.vim @ 33863:3b8089d550eb v9.0.2141
patch 9.0.2141: [security]: buffer-overflow in suggest_trie_walk
Commit: https://github.com/vim/vim/commit/0fb375aae608d7306b4baf9c1f906961f32e2abf
Author: Christian Brabandt <cb@256bit.org>
Date: Wed Nov 29 10:23:39 2023 +0100
patch 9.0.2141: [security]: buffer-overflow in suggest_trie_walk
Problem: [security]: buffer-overflow in suggest_trie_walk
Solution: Check n before using it as index into byts array
Basically, n as an index into the byts array, can point to beyond the byts
array. So let's double check, that n is within the expected range after
incrementing it from sp->ts_curi and bail out if it would be invalid.
Reported by @henices, thanks!
Signed-off-by: Christian Brabandt <cb@256bit.org>
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Sun, 10 Dec 2023 15:16:03 +0100 |
| parents | 457ea0570b6f |
| children |
line wrap: on
line source
" Tests for the preview window source check.vim CheckFeature quickfix func Test_Psearch() " this used to cause ml_get errors help let wincount = winnr('$') 0f ps. call assert_equal(wincount + 1, winnr('$')) pclose call assert_equal(wincount, winnr('$')) bwipe endfunc func Test_window_preview() CheckFeature quickfix " Open a preview window pedit Xa call assert_equal(2, winnr('$')) call assert_equal(0, &previewwindow) " Go to the preview window wincmd P call assert_equal(1, &previewwindow) call assert_equal('preview', win_gettype()) " Close preview window wincmd z call assert_equal(1, winnr('$')) call assert_equal(0, &previewwindow) call assert_fails('wincmd P', 'E441:') endfunc func Test_window_preview_from_help() CheckFeature quickfix filetype on call writefile(['/* some C code */'], 'Xpreview.c', 'D') help pedit Xpreview.c wincmd P call assert_equal(1, &previewwindow) call assert_equal('c', &filetype) wincmd z filetype off close endfunc func Test_multiple_preview_windows() new set previewwindow new call assert_fails('set previewwindow', 'E590:') %bw! endfunc " vim: shiftwidth=2 sts=2 expandtab