Mercurial > vim
view src/testdir/test_backup.vim @ 33863:3b8089d550eb v9.0.2141
patch 9.0.2141: [security]: buffer-overflow in suggest_trie_walk
Commit: https://github.com/vim/vim/commit/0fb375aae608d7306b4baf9c1f906961f32e2abf
Author: Christian Brabandt <cb@256bit.org>
Date: Wed Nov 29 10:23:39 2023 +0100
patch 9.0.2141: [security]: buffer-overflow in suggest_trie_walk
Problem: [security]: buffer-overflow in suggest_trie_walk
Solution: Check n before using it as index into byts array
Basically, n as an index into the byts array, can point to beyond the byts
array. So let's double check, that n is within the expected range after
incrementing it from sp->ts_curi and bail out if it would be invalid.
Reported by @henices, thanks!
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Sun, 10 Dec 2023 15:16:03 +0100 |
parents | ba5ca7c7d44c |
children |
line wrap: on
line source
" Tests for the backup function source check.vim func Test_backup() set backup backupdir=. backupskip= new call setline(1, ['line1', 'line2']) :f Xbackup.txt :w! Xbackup.txt " backup file is only created after " writing a second time (before overwriting) :w! Xbackup.txt let l = readfile('Xbackup.txt~') call assert_equal(['line1', 'line2'], l) bw! set backup&vim backupdir&vim backupskip&vim call delete('Xbackup.txt') call delete('Xbackup.txt~') endfunc func Test_backup_backupskip() set backup backupdir=. backupskip=*.txt new call setline(1, ['line1', 'line2']) :f Xbackup.txt :w! Xbackup.txt " backup file is only created after " writing a second time (before overwriting) :w! Xbackup.txt call assert_false(filereadable('Xbackup.txt~')) bw! set backup&vim backupdir&vim backupskip&vim call delete('Xbackup.txt') call delete('Xbackup.txt~') endfunc func Test_backup2() set backup backupdir=.// backupskip= new call setline(1, ['line1', 'line2', 'line3']) :f Xbackup.txt :w! Xbackup.txt " backup file is only created after " writing a second time (before overwriting) :w! Xbackup.txt sp *Xbackup.txt~ call assert_equal(['line1', 'line2', 'line3'], getline(1,'$')) let f = expand('%') call assert_match('%testdir%Xbackup.txt\~', f) bw! bw! call delete('Xbackup.txt') call delete(f) set backup&vim backupdir&vim backupskip&vim endfunc func Test_backup2_backupcopy() set backup backupdir=.// backupcopy=yes backupskip= new call setline(1, ['line1', 'line2', 'line3']) :f Xbackup.txt :w! Xbackup.txt " backup file is only created after " writing a second time (before overwriting) :w! Xbackup.txt sp *Xbackup.txt~ call assert_equal(['line1', 'line2', 'line3'], getline(1,'$')) let f = expand('%') call assert_match('%testdir%Xbackup.txt\~', f) bw! bw! call delete('Xbackup.txt') call delete(f) set backup&vim backupdir&vim backupcopy&vim backupskip&vim endfunc " Test for using a non-existing directory as a backup directory func Test_non_existing_backupdir() set backupdir=./non_existing_dir backupskip= call writefile(['line1'], 'Xbackupdir', 'D') new Xbackupdir call assert_fails('write', 'E510:') set backupdir&vim backupskip&vim endfunc " vim: shiftwidth=2 sts=2 expandtab