Mercurial > vim
view src/testdir/thread_util.py @ 34379:37b4c89ba420 v9.1.0116
patch 9.1.0116: win_split_ins may not check available room
Commit: https://github.com/vim/vim/commit/0fd44a5ad81ade342cb54d8984965bdedd2272c8
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Feb 20 20:28:15 2024 +0100
patch 9.1.0116: win_split_ins may not check available room
Problem: win_split_ins has no check for E36 when moving an existing
window
Solution: check for room and fix the issues in f_win_splitmove()
(Sean Dewar)
win_split_ins has no check for E36 when moving an existing window,
allowing for layouts with many overlapping zero-sized windows to be
created (which may also cause drawing issues with tablines and such).
f_win_splitmove also has some bugs.
So check for room and fix the issues in f_win_splitmove. Handle failure
in the two relevant win_split_ins callers by restoring the original
layout, and factor the common logic into win_splitmove.
Don't check for room when opening an autocommand window, as it's a
temporary window that's rarely interacted with or drawn anyhow, and is
rather important for some autocommands.
Issues fixed in f_win_splitmove:
- Error if splitting is disallowed.
- Fix heap-use-after-frees if autocommands fired from switching to "targetwin"
close "wp" or "oldwin".
- Fix splitting the wrong window if autocommands fired from switching to
"targetwin" switch to a different window.
- Ensure -1 is returned for all errors.
Also handle allocation failure a bit earlier in make_snapshot (callers,
except win_splitmove, don't really care if a snapshot can't be made, so
just ignore the return value).
Note: Test_smoothscroll_in_zero_width_window failed after these changes with
E36, as it was using the previous behaviour to create a zero-width window.
I've fixed the test such that it fails with UBSAN as expected when v9.0.1367 is
reverted (and simplified it too).
related: #14042
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 20 Feb 2024 22:30:04 +0100 |
parents | 06e3c6bac36d |
children |
line wrap: on
line source
import platform if platform.system() == 'Darwin': from ctypes import ( CDLL, POINTER, Structure, byref, c_int, c_uint, c_uint32, c_void_p, sizeof ) from ctypes.util import find_library class ThreadTimeConstraintPolicy(Structure): _fields_ = [ ("period", c_uint32), ("computation", c_uint32), ("constraint", c_uint32), ("preemptible", c_uint) ] _libc = CDLL(find_library('c')) THREAD_TIME_CONSTRAINT_POLICY = c_uint(2) THREAD_TIME_CONSTRAINT_POLICY_COUNT = c_uint( int(sizeof(ThreadTimeConstraintPolicy) / sizeof(c_int))) _libc.pthread_self.restype = c_void_p _libc.pthread_mach_thread_np.restype = c_uint _libc.pthread_mach_thread_np.argtypes = [c_void_p] _libc.thread_policy_get.restype = c_int _libc.thread_policy_get.argtypes = [ c_uint, c_uint, c_void_p, POINTER(c_uint), POINTER(c_uint) ] _libc.thread_policy_set.restype = c_int _libc.thread_policy_set.argtypes = [ c_uint, c_uint, c_void_p, c_uint ] def _mach_thread_self(): return _libc.pthread_mach_thread_np(_libc.pthread_self()) def _get_time_constraint_policy(default=False): thread = _mach_thread_self() policy_info = ThreadTimeConstraintPolicy() policy_infoCnt = THREAD_TIME_CONSTRAINT_POLICY_COUNT get_default = c_uint(default) kret = _libc.thread_policy_get( thread, THREAD_TIME_CONSTRAINT_POLICY, byref(policy_info), byref(policy_infoCnt), byref(get_default)) if kret != 0: return None return policy_info def _set_time_constraint_policy(policy_info): thread = _mach_thread_self() policy_infoCnt = THREAD_TIME_CONSTRAINT_POLICY_COUNT kret = _libc.thread_policy_set( thread, THREAD_TIME_CONSTRAINT_POLICY, byref(policy_info), policy_infoCnt) if kret != 0: raise OSError(kret) def set_high_priority(): policy_info = _get_time_constraint_policy(default=True) if not policy_info: return policy_info.preemptible = c_uint(False) _set_time_constraint_policy(policy_info)