Mercurial > vim
view src/testdir/test_windows_home.vim @ 34379:37b4c89ba420 v9.1.0116
patch 9.1.0116: win_split_ins may not check available room
Commit: https://github.com/vim/vim/commit/0fd44a5ad81ade342cb54d8984965bdedd2272c8
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Feb 20 20:28:15 2024 +0100
patch 9.1.0116: win_split_ins may not check available room
Problem: win_split_ins has no check for E36 when moving an existing
window
Solution: check for room and fix the issues in f_win_splitmove()
(Sean Dewar)
win_split_ins has no check for E36 when moving an existing window,
allowing for layouts with many overlapping zero-sized windows to be
created (which may also cause drawing issues with tablines and such).
f_win_splitmove also has some bugs.
So check for room and fix the issues in f_win_splitmove. Handle failure
in the two relevant win_split_ins callers by restoring the original
layout, and factor the common logic into win_splitmove.
Don't check for room when opening an autocommand window, as it's a
temporary window that's rarely interacted with or drawn anyhow, and is
rather important for some autocommands.
Issues fixed in f_win_splitmove:
- Error if splitting is disallowed.
- Fix heap-use-after-frees if autocommands fired from switching to "targetwin"
close "wp" or "oldwin".
- Fix splitting the wrong window if autocommands fired from switching to
"targetwin" switch to a different window.
- Ensure -1 is returned for all errors.
Also handle allocation failure a bit earlier in make_snapshot (callers,
except win_splitmove, don't really care if a snapshot can't be made, so
just ignore the return value).
Note: Test_smoothscroll_in_zero_width_window failed after these changes with
E36, as it was using the previous behaviour to create a zero-width window.
I've fixed the test such that it fails with UBSAN as expected when v9.0.1367 is
reverted (and simplified it too).
related: #14042
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 20 Feb 2024 22:30:04 +0100 |
parents | 08940efa6b4e |
children |
line wrap: on
line source
" Test for $HOME on Windows. source check.vim CheckMSWindows let s:env = {} func s:restore_env() for i in keys(s:env) exe 'let ' . i . '=s:env["' . i . '"]' endfor endfunc func s:save_env(...) for i in a:000 exe 'let s:env["' . i . '"]=' . i endfor endfunc func s:unlet_env(...) for i in a:000 exe 'let ' . i . '=""' endfor endfunc func CheckHomeIsMissingFromSubprocessEnvironment() silent! let out = system('set') let env = filter(split(out, "\n"), 'v:val=~"^HOME="') call assert_equal(0, len(env)) endfunc func CheckHomeIsInSubprocessEnvironment(exp) silent! let out = system('set') let env = filter(split(out, "\n"), 'v:val=~"^HOME="') let home = len(env) == 0 ? "" : substitute(env[0], '[^=]\+=', '', '') call assert_equal(a:exp, home) endfunc func CheckHome(exp, ...) call assert_equal(a:exp, $HOME) call assert_equal(a:exp, expand('~', ':p')) if !a:0 call CheckHomeIsMissingFromSubprocessEnvironment() else call CheckHomeIsInSubprocessEnvironment(a:1) endif endfunc func Test_WindowsHome() command! -nargs=* SaveEnv call <SID>save_env(<f-args>) command! -nargs=* RestoreEnv call <SID>restore_env() command! -nargs=* UnletEnv call <SID>unlet_env(<f-args>) set noshellslash let save_home = $HOME SaveEnv $USERPROFILE $HOMEDRIVE $HOMEPATH try " Normal behavior: use $HOMEDRIVE and $HOMEPATH, ignore $USERPROFILE let $USERPROFILE = 'unused' let $HOMEDRIVE = 'C:' let $HOMEPATH = '\foobar' let $HOME = '' " Force recomputing "homedir" call CheckHome('C:\foobar') " Same, but with $HOMEPATH not set UnletEnv $HOMEPATH let $HOME = '' " Force recomputing "homedir" call CheckHome('C:\') " Use $USERPROFILE if $HOMEPATH and $HOMEDRIVE are empty UnletEnv $HOMEDRIVE $HOMEPATH let $USERPROFILE = 'C:\foo' let $HOME = '' " Force recomputing "homedir" call CheckHome('C:\foo') " If $HOME is set the others don't matter let $HOME = 'C:\bar' let $USERPROFILE = 'unused' let $HOMEDRIVE = 'unused' let $HOMEPATH = 'unused' call CheckHome('C:\bar', 'C:\bar') " If $HOME contains %USERPROFILE% it is expanded let $USERPROFILE = 'C:\foo' let $HOME = '%USERPROFILE%\bar' let $HOMEDRIVE = 'unused' let $HOMEPATH = 'unused' call CheckHome('C:\foo\bar', '%USERPROFILE%\bar') " Invalid $HOME is kept let $USERPROFILE = 'C:\foo' let $HOME = '%USERPROFILE' let $HOMEDRIVE = 'unused' let $HOMEPATH = 'unused' call CheckHome('%USERPROFILE', '%USERPROFILE') " %USERPROFILE% not at start of $HOME is not expanded let $USERPROFILE = 'unused' let $HOME = 'C:\%USERPROFILE%' let $HOMEDRIVE = 'unused' let $HOMEPATH = 'unused' call CheckHome('C:\%USERPROFILE%', 'C:\%USERPROFILE%') if has('channel') RestoreEnv let $HOME = save_home let env = '' let job = job_start('cmd /c set', {'out_cb': {ch,x->[env,execute('let env=x')]}}) sleep 1 let env = filter(split(env, "\n"), 'v:val=="HOME"') let home = len(env) == 0 ? "" : env[0] call assert_equal('', home) endif finally RestoreEnv delcommand SaveEnv delcommand RestoreEnv delcommand UnletEnv endtry endfunc " vim: shiftwidth=2 sts=2 expandtab