Mercurial > vim
view src/testdir/test_tab.vim @ 34379:37b4c89ba420 v9.1.0116
patch 9.1.0116: win_split_ins may not check available room
Commit: https://github.com/vim/vim/commit/0fd44a5ad81ade342cb54d8984965bdedd2272c8
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Feb 20 20:28:15 2024 +0100
patch 9.1.0116: win_split_ins may not check available room
Problem: win_split_ins has no check for E36 when moving an existing
window
Solution: check for room and fix the issues in f_win_splitmove()
(Sean Dewar)
win_split_ins has no check for E36 when moving an existing window,
allowing for layouts with many overlapping zero-sized windows to be
created (which may also cause drawing issues with tablines and such).
f_win_splitmove also has some bugs.
So check for room and fix the issues in f_win_splitmove. Handle failure
in the two relevant win_split_ins callers by restoring the original
layout, and factor the common logic into win_splitmove.
Don't check for room when opening an autocommand window, as it's a
temporary window that's rarely interacted with or drawn anyhow, and is
rather important for some autocommands.
Issues fixed in f_win_splitmove:
- Error if splitting is disallowed.
- Fix heap-use-after-frees if autocommands fired from switching to "targetwin"
close "wp" or "oldwin".
- Fix splitting the wrong window if autocommands fired from switching to
"targetwin" switch to a different window.
- Ensure -1 is returned for all errors.
Also handle allocation failure a bit earlier in make_snapshot (callers,
except win_splitmove, don't really care if a snapshot can't be made, so
just ignore the return value).
Note: Test_smoothscroll_in_zero_width_window failed after these changes with
E36, as it was using the previous behaviour to create a zero-width window.
I've fixed the test such that it fails with UBSAN as expected when v9.0.1367 is
reverted (and simplified it too).
related: #14042
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 20 Feb 2024 22:30:04 +0100 |
parents | 08940efa6b4e |
children |
line wrap: on
line source
" Various tests for inserting a Tab. " Tests for "r<Tab>" with 'smarttab' and 'expandtab' set/not set. " Also test that dv_ works correctly func Test_smarttab() enew! set smarttab expandtab ts=8 sw=4 " make sure that backspace works, no matter what termcap is used exe "set t_kD=\<C-V>x7f t_kb=\<C-V>x08" call append(0, ['start text', \ "\t\tsome test text", \ 'test text', \ "\t\tother test text", \ ' a cde', \ ' f ghi', \ 'test text', \ ' Second line beginning with whitespace' \ ]) call cursor(1, 1) exe "normal /some\<CR>" exe "normal r\t" call assert_equal("\t\t ome test text", getline('.')) set noexpandtab exe "normal /other\<CR>" exe "normal r\t" call assert_equal("\t\t ther test text", getline('.')) " Test replacing with Tabs and then backspacing to undo it exe "normal j0wR\t\t\t\<BS>\<BS>\<BS>" call assert_equal(" a cde", getline('.')) " Test replacing with Tabs exe "normal j0wR\t\t\t" call assert_equal(" \t\thi", getline('.')) " Test that copyindent works with expandtab set set expandtab smartindent copyindent ts=8 sw=8 sts=8 exe "normal jo{\<CR>x" call assert_equal('{', getline(line('.') - 1)) call assert_equal(' x', getline('.')) set nosol exe "normal /Second line/\<CR>" exe "normal fwdv_" call assert_equal(' with whitespace', getline('.')) enew! set expandtab& smartindent& copyindent& ts& sw& sts& endfunc func Test_softtabstop() new set sts=0 sw=0 exe "normal ix\<Tab>x\<Esc>" call assert_equal("x\tx", getline(1)) call setline(1, '') set sts=4 exe "normal ix\<Tab>x\<Esc>" call assert_equal("x x", getline(1)) call setline(1, '') set sts=-1 sw=4 exe "normal ix\<Tab>x\<Esc>" call assert_equal("x x", getline(1)) call setline(1, 'x ') set sts=0 sw=0 backspace=start exe "normal A\<BS>x\<Esc>" call assert_equal("x x", getline(1)) call setline(1, 'x ') set sts=4 exe "normal A\<BS>x\<Esc>" call assert_equal("x x", getline(1)) call setline(1, 'x ') set sts=-1 sw=4 exe "normal A\<BS>x\<Esc>" call assert_equal("x x", getline(1)) call setline(1, 'x') set sts=-1 sw=0 smarttab exe "normal I\<Tab>\<Esc>" call assert_equal("\tx", getline(1)) call setline(1, 'x') exe "normal I\<Tab>\<BS>\<Esc>" call assert_equal("x", getline(1)) set sts=0 sw=0 backspace& nosmarttab bwipe! endfunc " vim: shiftwidth=2 sts=2 expandtab