Mercurial > vim
view src/testdir/test_shift.vim @ 34379:37b4c89ba420 v9.1.0116
patch 9.1.0116: win_split_ins may not check available room
Commit: https://github.com/vim/vim/commit/0fd44a5ad81ade342cb54d8984965bdedd2272c8
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Feb 20 20:28:15 2024 +0100
patch 9.1.0116: win_split_ins may not check available room
Problem: win_split_ins has no check for E36 when moving an existing
window
Solution: check for room and fix the issues in f_win_splitmove()
(Sean Dewar)
win_split_ins has no check for E36 when moving an existing window,
allowing for layouts with many overlapping zero-sized windows to be
created (which may also cause drawing issues with tablines and such).
f_win_splitmove also has some bugs.
So check for room and fix the issues in f_win_splitmove. Handle failure
in the two relevant win_split_ins callers by restoring the original
layout, and factor the common logic into win_splitmove.
Don't check for room when opening an autocommand window, as it's a
temporary window that's rarely interacted with or drawn anyhow, and is
rather important for some autocommands.
Issues fixed in f_win_splitmove:
- Error if splitting is disallowed.
- Fix heap-use-after-frees if autocommands fired from switching to "targetwin"
close "wp" or "oldwin".
- Fix splitting the wrong window if autocommands fired from switching to
"targetwin" switch to a different window.
- Ensure -1 is returned for all errors.
Also handle allocation failure a bit earlier in make_snapshot (callers,
except win_splitmove, don't really care if a snapshot can't be made, so
just ignore the return value).
Note: Test_smoothscroll_in_zero_width_window failed after these changes with
E36, as it was using the previous behaviour to create a zero-width window.
I've fixed the test such that it fails with UBSAN as expected when v9.0.1367 is
reverted (and simplified it too).
related: #14042
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Tue, 20 Feb 2024 22:30:04 +0100 |
| parents | 08940efa6b4e |
| children |
line wrap: on
line source
" Test shifting lines with :> and :< source check.vim func Test_ex_shift_right() set shiftwidth=2 " shift right current line. call setline(1, range(1, 5)) 2 > 3 >> call assert_equal(['1', \ ' 2', \ ' 3', \ '4', \ '5'], getline(1, '$')) " shift right with range. call setline(1, range(1, 4)) 2,3>> call assert_equal(['1', \ ' 2', \ ' 3', \ '4', \ '5'], getline(1, '$')) " shift right with range and count. call setline(1, range(1, 4)) 2>3 call assert_equal(['1', \ ' 2', \ ' 3', \ ' 4', \ '5'], getline(1, '$')) bw! set shiftwidth& endfunc func Test_ex_shift_left() set shiftwidth=2 call setline(1, range(1, 5)) %>>> " left shift current line. 2< 3<< 4<<<<< call assert_equal([' 1', \ ' 2', \ ' 3', \ '4', \ ' 5'], getline(1, '$')) " shift right with range. call setline(1, range(1, 5)) %>>> 2,3<< call assert_equal([' 1', \ ' 2', \ ' 3', \ ' 4', \ ' 5'], getline(1, '$')) " shift right with range and count. call setline(1, range(1, 5)) %>>> 2<<3 call assert_equal([' 1', \ ' 2', \ ' 3', \ ' 4', \ ' 5'], getline(1, '$')) bw! set shiftwidth& endfunc func Test_ex_shift_rightleft() CheckFeature rightleft set shiftwidth=2 rightleft call setline(1, range(1, 4)) 2,3<< call assert_equal(['1', \ ' 2', \ ' 3', \ '4'], getline(1, '$')) 3,4> call assert_equal(['1', \ ' 2', \ ' 3', \ '4'], getline(1, '$')) bw! set rightleft& shiftwidth& endfunc func Test_ex_shift_errors() call assert_fails('><', 'E488:') call assert_fails('<>', 'E488:') call assert_fails('>!', 'E477:') call assert_fails('<!', 'E477:') call assert_fails('2,1>', 'E493:') call assert_fails('2,1<', 'E493:') endfunc " vim: shiftwidth=2 sts=2 expandtab