Mercurial > vim
view src/testdir/test_retab.vim @ 34379:37b4c89ba420 v9.1.0116
patch 9.1.0116: win_split_ins may not check available room
Commit: https://github.com/vim/vim/commit/0fd44a5ad81ade342cb54d8984965bdedd2272c8
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Feb 20 20:28:15 2024 +0100
patch 9.1.0116: win_split_ins may not check available room
Problem: win_split_ins has no check for E36 when moving an existing
window
Solution: check for room and fix the issues in f_win_splitmove()
(Sean Dewar)
win_split_ins has no check for E36 when moving an existing window,
allowing for layouts with many overlapping zero-sized windows to be
created (which may also cause drawing issues with tablines and such).
f_win_splitmove also has some bugs.
So check for room and fix the issues in f_win_splitmove. Handle failure
in the two relevant win_split_ins callers by restoring the original
layout, and factor the common logic into win_splitmove.
Don't check for room when opening an autocommand window, as it's a
temporary window that's rarely interacted with or drawn anyhow, and is
rather important for some autocommands.
Issues fixed in f_win_splitmove:
- Error if splitting is disallowed.
- Fix heap-use-after-frees if autocommands fired from switching to "targetwin"
close "wp" or "oldwin".
- Fix splitting the wrong window if autocommands fired from switching to
"targetwin" switch to a different window.
- Ensure -1 is returned for all errors.
Also handle allocation failure a bit earlier in make_snapshot (callers,
except win_splitmove, don't really care if a snapshot can't be made, so
just ignore the return value).
Note: Test_smoothscroll_in_zero_width_window failed after these changes with
E36, as it was using the previous behaviour to create a zero-width window.
I've fixed the test such that it fails with UBSAN as expected when v9.0.1367 is
reverted (and simplified it too).
related: #14042
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Tue, 20 Feb 2024 22:30:04 +0100 |
| parents | 6a6c56354cfc |
| children |
line wrap: on
line source
" Test :retab source check.vim func SetUp() new call setline(1, "\ta \t b c ") endfunc func TearDown() bwipe! endfunc func Retab(bang, n) let l:old_tabstop = &tabstop let l:old_line = getline(1) exe "retab" . a:bang . a:n let l:line = getline(1) call setline(1, l:old_line) if a:n > 0 " :retab changes 'tabstop' to n with argument n > 0. call assert_equal(a:n, &tabstop) exe 'set tabstop=' . l:old_tabstop else " :retab does not change 'tabstop' with empty or n <= 0. call assert_equal(l:old_tabstop, &tabstop) endif return l:line endfunc func Test_retab() set tabstop=8 noexpandtab call assert_equal("\ta\t b c ", Retab('', '')) call assert_equal("\ta\t b c ", Retab('', 0)) call assert_equal("\ta\t b c ", Retab('', 8)) call assert_equal("\ta\t b\t c\t ", Retab('!', '')) call assert_equal("\ta\t b\t c\t ", Retab('!', 0)) call assert_equal("\ta\t b\t c\t ", Retab('!', 8)) call assert_equal("\t\ta\t\t\tb c ", Retab('', 4)) call assert_equal("\t\ta\t\t\tb\t\t c\t ", Retab('!', 4)) call assert_equal(" a\t\tb c ", Retab('', 10)) call assert_equal(" a\t\tb c ", Retab('!', 10)) set tabstop=8 expandtab call assert_equal(" a b c ", Retab('', '')) call assert_equal(" a b c ", Retab('', 0)) call assert_equal(" a b c ", Retab('', 8)) call assert_equal(" a b c ", Retab('!', '')) call assert_equal(" a b c ", Retab('!', 0)) call assert_equal(" a b c ", Retab('!', 8)) call assert_equal(" a b c ", Retab(' ', 4)) call assert_equal(" a b c ", Retab('!', 4)) call assert_equal(" a b c ", Retab(' ', 10)) call assert_equal(" a b c ", Retab('!', 10)) set tabstop=4 noexpandtab call assert_equal("\ta\t\tb c ", Retab('', '')) call assert_equal("\ta\t\tb\t\t c\t ", Retab('!', '')) call assert_equal("\t a\t\t\tb c ", Retab('', 3)) call assert_equal("\t a\t\t\tb\t\t\tc\t ", Retab('!', 3)) call assert_equal(" a\t b c ", Retab('', 5)) call assert_equal(" a\t b\t\t c\t ", Retab('!', 5)) set tabstop=4 expandtab call assert_equal(" a b c ", Retab('', '')) call assert_equal(" a b c ", Retab('!', '')) call assert_equal(" a b c ", Retab('', 3)) call assert_equal(" a b c ", Retab('!', 3)) call assert_equal(" a b c ", Retab('', 5)) call assert_equal(" a b c ", Retab('!', 5)) set tabstop& expandtab& endfunc func Test_retab_error() call assert_fails('retab -1', 'E487:') call assert_fails('retab! -1', 'E487:') call assert_fails('ret -1000', 'E487:') call assert_fails('ret 10000', 'E475:') call assert_fails('ret 80000000000000000000', 'E475:') endfunc func RetabLoop() while 1 set ts=4000 retab 4 endwhile endfunc func Test_retab_endless() " inside try/catch we can catch the error message call setline(1, "\t0\t") let caught = 'no' try call RetabLoop() catch /E1240:/ let caught = v:exception endtry call assert_match('E1240:', caught) set tabstop& endfunc func Test_nocatch_retab_endless() " when not inside try/catch an interrupt is generated to get out of loops call setline(1, "\t0\t") call assert_fails('call RetabLoop()', ['E1240:', 'Interrupted']) set tabstop& endfunc " vim: shiftwidth=2 sts=2 expandtab