Mercurial > vim
view src/testdir/test_rename.vim @ 34379:37b4c89ba420 v9.1.0116
patch 9.1.0116: win_split_ins may not check available room
Commit: https://github.com/vim/vim/commit/0fd44a5ad81ade342cb54d8984965bdedd2272c8
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Feb 20 20:28:15 2024 +0100
patch 9.1.0116: win_split_ins may not check available room
Problem: win_split_ins has no check for E36 when moving an existing
window
Solution: check for room and fix the issues in f_win_splitmove()
(Sean Dewar)
win_split_ins has no check for E36 when moving an existing window,
allowing for layouts with many overlapping zero-sized windows to be
created (which may also cause drawing issues with tablines and such).
f_win_splitmove also has some bugs.
So check for room and fix the issues in f_win_splitmove. Handle failure
in the two relevant win_split_ins callers by restoring the original
layout, and factor the common logic into win_splitmove.
Don't check for room when opening an autocommand window, as it's a
temporary window that's rarely interacted with or drawn anyhow, and is
rather important for some autocommands.
Issues fixed in f_win_splitmove:
- Error if splitting is disallowed.
- Fix heap-use-after-frees if autocommands fired from switching to "targetwin"
close "wp" or "oldwin".
- Fix splitting the wrong window if autocommands fired from switching to
"targetwin" switch to a different window.
- Ensure -1 is returned for all errors.
Also handle allocation failure a bit earlier in make_snapshot (callers,
except win_splitmove, don't really care if a snapshot can't be made, so
just ignore the return value).
Note: Test_smoothscroll_in_zero_width_window failed after these changes with
E36, as it was using the previous behaviour to create a zero-width window.
I've fixed the test such that it fails with UBSAN as expected when v9.0.1367 is
reverted (and simplified it too).
related: #14042
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 20 Feb 2024 22:30:04 +0100 |
parents | de319bf98a39 |
children |
line wrap: on
line source
" Test rename() source shared.vim func Test_rename_file_to_file() call writefile(['foo'], 'Xrename1') call assert_equal(0, rename('Xrename1', 'Xrename2')) call assert_equal('', glob('Xrename1')) call assert_equal(['foo'], readfile('Xrename2')) " When the destination file already exists, it should be overwritten. call writefile(['foo'], 'Xrename1') call writefile(['bar'], 'Xrename2', 'D') call assert_equal(0, rename('Xrename1', 'Xrename2')) call assert_equal('', glob('Xrename1')) call assert_equal(['foo'], readfile('Xrename2')) call delete('Xrename2') endfunc func Test_rename_file_ignore_case() " With 'fileignorecase', renaming file will go through a temp file " when the source and destination file only differ by case. set fileignorecase call writefile(['foo'], 'Xrename') call assert_equal(0, 'Xrename'->rename('XRENAME')) call assert_equal(['foo'], readfile('XRENAME')) set fileignorecase& call delete('XRENAME') endfunc func Test_rename_same_file() call writefile(['foo'], 'Xrename', 'D') " When the source and destination are the same file, nothing " should be done. The source file should not be deleted. call assert_equal(0, rename('Xrename', 'Xrename')) call assert_equal(['foo'], readfile('Xrename')) call assert_equal(0, rename('./Xrename', 'Xrename')) call assert_equal(['foo'], readfile('Xrename')) endfunc func Test_rename_dir_to_dir() call mkdir('Xrenamedir1') call writefile(['foo'], 'Xrenamedir1/Xrenamefile') call assert_equal(0, rename('Xrenamedir1', 'Xrenamedir2')) call assert_equal('', glob('Xrenamedir1')) call assert_equal(['foo'], readfile('Xrenamedir2/Xrenamefile')) call delete('Xrenamedir2/Xrenamefile') call delete('Xrenamedir2', 'd') endfunc func Test_rename_same_dir() call mkdir('Xrenamedir', 'R') call writefile(['foo'], 'Xrenamedir/Xrenamefile') call assert_equal(0, rename('Xrenamedir', 'Xrenamedir')) call assert_equal(['foo'], readfile('Xrenamedir/Xrenamefile')) endfunc func Test_rename_copy() " Check that when original file can't be deleted, rename() " still succeeds but copies the file. call mkdir('Xrenamedir', 'R') call writefile(['foo'], 'Xrenamedir/Xrenamefile') call setfperm('Xrenamedir', 'r-xr-xr-x') call assert_equal(0, rename('Xrenamedir/Xrenamefile', 'Xrenamefile')) if !has('win32') && !IsRoot() " On Windows, the source file is removed despite " its directory being made not writable. call assert_equal(['foo'], readfile('Xrenamedir/Xrenamefile')) endif call assert_equal(['foo'], readfile('Xrenamefile')) call setfperm('Xrenamedir', 'rwxrwxrwx') call delete('Xrenamefile') endfunc func Test_rename_fails() call writefile(['foo'], 'Xrenamefile', 'D') " Can't rename into a non-existing directory. call assert_notequal(0, rename('Xrenamefile', 'Xdoesnotexist/Xrenamefile')) " Can't rename a non-existing file. call assert_notequal(0, rename('Xdoesnotexist', 'Xrenamefile2')) call assert_equal('', glob('Xrenamefile2')) " When rename() fails, the destination file should not be deleted. call assert_notequal(0, rename('Xdoesnotexist', 'Xrenamefile')) call assert_equal(['foo'], readfile('Xrenamefile')) " Can't rename to en empty file name. call assert_notequal(0, rename('Xrenamefile', '')) call assert_fails('call rename("Xrenamefile", [])', 'E730:') call assert_fails('call rename(0z, "Xrenamefile")', 'E976:') endfunc " vim: shiftwidth=2 sts=2 expandtab