Mercurial > vim
view src/testdir/test_pyx2.vim @ 34379:37b4c89ba420 v9.1.0116
patch 9.1.0116: win_split_ins may not check available room
Commit: https://github.com/vim/vim/commit/0fd44a5ad81ade342cb54d8984965bdedd2272c8
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Feb 20 20:28:15 2024 +0100
patch 9.1.0116: win_split_ins may not check available room
Problem: win_split_ins has no check for E36 when moving an existing
window
Solution: check for room and fix the issues in f_win_splitmove()
(Sean Dewar)
win_split_ins has no check for E36 when moving an existing window,
allowing for layouts with many overlapping zero-sized windows to be
created (which may also cause drawing issues with tablines and such).
f_win_splitmove also has some bugs.
So check for room and fix the issues in f_win_splitmove. Handle failure
in the two relevant win_split_ins callers by restoring the original
layout, and factor the common logic into win_splitmove.
Don't check for room when opening an autocommand window, as it's a
temporary window that's rarely interacted with or drawn anyhow, and is
rather important for some autocommands.
Issues fixed in f_win_splitmove:
- Error if splitting is disallowed.
- Fix heap-use-after-frees if autocommands fired from switching to "targetwin"
close "wp" or "oldwin".
- Fix splitting the wrong window if autocommands fired from switching to
"targetwin" switch to a different window.
- Ensure -1 is returned for all errors.
Also handle allocation failure a bit earlier in make_snapshot (callers,
except win_splitmove, don't really care if a snapshot can't be made, so
just ignore the return value).
Note: Test_smoothscroll_in_zero_width_window failed after these changes with
E36, as it was using the previous behaviour to create a zero-width window.
I've fixed the test such that it fails with UBSAN as expected when v9.0.1367 is
reverted (and simplified it too).
related: #14042
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 20 Feb 2024 22:30:04 +0100 |
parents | 5f9c2c7d3d73 |
children |
line wrap: on
line source
" Test for pyx* commands and functions with Python 2. set pyx=2 source check.vim CheckFeature python let s:py2pattern = '^2\.[0-7]\.\d\+' let s:py3pattern = '^3\.\d\+\.\d\+' func Test_has_pythonx() call assert_true(has('pythonx')) endfunc func Test_pyx() redir => var pyx << trim EOF import sys print(sys.version) EOF redir END call assert_match(s:py2pattern, split(var)[0]) endfunc func Test_pyxdo() pyx import sys enew pyxdo return sys.version.split("\n")[0] call assert_match(s:py2pattern, split(getline('.'))[0]) endfunc func Test_pyxeval() pyx import sys call assert_match(s:py2pattern, split('sys.version'->pyxeval())[0]) endfunc func Test_pyxfile() " No special comments nor shebangs redir => var pyxfile pyxfile/pyx.py redir END call assert_match(s:py2pattern, split(var)[0]) " Python 2 special comment redir => var pyxfile pyxfile/py2_magic.py redir END call assert_match(s:py2pattern, split(var)[0]) " Python 2 shebang redir => var pyxfile pyxfile/py2_shebang.py redir END call assert_match(s:py2pattern, split(var)[0]) if has('python3') " Python 3 special comment redir => var pyxfile pyxfile/py3_magic.py redir END call assert_match(s:py3pattern, split(var)[0]) " Python 3 shebang redir => var pyxfile pyxfile/py3_shebang.py redir END call assert_match(s:py3pattern, split(var)[0]) endif endfunc func Test_Catch_Exception_Message() try pyx raise RuntimeError( 'TEST' ) catch /.*/ call assert_match( '^Vim(.*):RuntimeError: TEST$', v:exception ) endtry endfunc " Test for various heredoc syntaxes func Test_pyx2_heredoc() pyx << END result='A' END pyx << result+='B' . pyx << trim END result+='C' END pyx << trim result+='D' . pyx << trim eof result+='E' eof call assert_equal('ABCDE', pyxeval('result')) endfunc " vim: shiftwidth=2 sts=2 expandtab