Mercurial > vim
view src/testdir/test_matchparen.vim @ 34379:37b4c89ba420 v9.1.0116
patch 9.1.0116: win_split_ins may not check available room
Commit: https://github.com/vim/vim/commit/0fd44a5ad81ade342cb54d8984965bdedd2272c8
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Feb 20 20:28:15 2024 +0100
patch 9.1.0116: win_split_ins may not check available room
Problem: win_split_ins has no check for E36 when moving an existing
window
Solution: check for room and fix the issues in f_win_splitmove()
(Sean Dewar)
win_split_ins has no check for E36 when moving an existing window,
allowing for layouts with many overlapping zero-sized windows to be
created (which may also cause drawing issues with tablines and such).
f_win_splitmove also has some bugs.
So check for room and fix the issues in f_win_splitmove. Handle failure
in the two relevant win_split_ins callers by restoring the original
layout, and factor the common logic into win_splitmove.
Don't check for room when opening an autocommand window, as it's a
temporary window that's rarely interacted with or drawn anyhow, and is
rather important for some autocommands.
Issues fixed in f_win_splitmove:
- Error if splitting is disallowed.
- Fix heap-use-after-frees if autocommands fired from switching to "targetwin"
close "wp" or "oldwin".
- Fix splitting the wrong window if autocommands fired from switching to
"targetwin" switch to a different window.
- Ensure -1 is returned for all errors.
Also handle allocation failure a bit earlier in make_snapshot (callers,
except win_splitmove, don't really care if a snapshot can't be made, so
just ignore the return value).
Note: Test_smoothscroll_in_zero_width_window failed after these changes with
E36, as it was using the previous behaviour to create a zero-width window.
I've fixed the test such that it fails with UBSAN as expected when v9.0.1367 is
reverted (and simplified it too).
related: #14042
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 20 Feb 2024 22:30:04 +0100 |
parents | 7b26c36e9b3b |
children | 2ee041017eb4 |
line wrap: on
line source
" Test for the matchparen plugin if !has('gui_running') && has('unix') set term=ansi endif source view_util.vim source check.vim source screendump.vim " Test for scrolling that modifies buffer during visual block func Test_visual_block_scroll() CheckScreendump let lines =<< trim END source $VIMRUNTIME/plugin/matchparen.vim set scrolloff=1 call setline(1, ['a', 'b', 'c', 'd', 'e', '', '{', '}', '{', 'f', 'g', '}']) call cursor(5, 1) END let filename = 'Xvisualblockmodifiedscroll' call writefile(lines, filename, 'D') let buf = RunVimInTerminal('-S '.filename, #{rows: 7}) call term_sendkeys(buf, "V\<C-D>\<C-D>") call VerifyScreenDump(buf, 'Test_display_visual_block_scroll', {}) call StopVimInTerminal(buf) endfunc " Test for clearing paren highlight when switching buffers func Test_matchparen_clear_highlight() CheckScreendump let lines =<< trim END source $VIMRUNTIME/plugin/matchparen.vim set hidden call setline(1, ['()']) normal 0 func OtherBuffer() enew exe "normal iaa\<Esc>0" endfunc END call writefile(lines, 'XMatchparenClear', 'D') let buf = RunVimInTerminal('-S XMatchparenClear', #{rows: 5}) call VerifyScreenDump(buf, 'Test_matchparen_clear_highlight_1', {}) call term_sendkeys(buf, ":call OtherBuffer()\<CR>:\<Esc>") call VerifyScreenDump(buf, 'Test_matchparen_clear_highlight_2', {}) call term_sendkeys(buf, "\<C-^>:\<Esc>") call VerifyScreenDump(buf, 'Test_matchparen_clear_highlight_1', {}) call term_sendkeys(buf, "\<C-^>:\<Esc>") call VerifyScreenDump(buf, 'Test_matchparen_clear_highlight_2', {}) call StopVimInTerminal(buf) endfunc " Test for scrolling that modifies buffer during visual block func Test_matchparen_pum_clear() CheckScreendump let lines =<< trim END source $VIMRUNTIME/plugin/matchparen.vim set completeopt=menuone call setline(1, ['aa', 'aaa', 'aaaa', '(a)']) call cursor(4, 3) END let filename = 'Xmatchparen' call writefile(lines, filename, 'D') let buf = RunVimInTerminal('-S '.filename, #{rows: 10}) call term_sendkeys(buf, "i\<C-N>\<C-N>") call VerifyScreenDump(buf, 'Test_matchparen_pum_clear_1', {}) call StopVimInTerminal(buf) endfunc " vim: shiftwidth=2 sts=2 expandtab