Mercurial > vim
view src/testdir/test_langmap.vim @ 34379:37b4c89ba420 v9.1.0116
patch 9.1.0116: win_split_ins may not check available room
Commit: https://github.com/vim/vim/commit/0fd44a5ad81ade342cb54d8984965bdedd2272c8
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Feb 20 20:28:15 2024 +0100
patch 9.1.0116: win_split_ins may not check available room
Problem: win_split_ins has no check for E36 when moving an existing
window
Solution: check for room and fix the issues in f_win_splitmove()
(Sean Dewar)
win_split_ins has no check for E36 when moving an existing window,
allowing for layouts with many overlapping zero-sized windows to be
created (which may also cause drawing issues with tablines and such).
f_win_splitmove also has some bugs.
So check for room and fix the issues in f_win_splitmove. Handle failure
in the two relevant win_split_ins callers by restoring the original
layout, and factor the common logic into win_splitmove.
Don't check for room when opening an autocommand window, as it's a
temporary window that's rarely interacted with or drawn anyhow, and is
rather important for some autocommands.
Issues fixed in f_win_splitmove:
- Error if splitting is disallowed.
- Fix heap-use-after-frees if autocommands fired from switching to "targetwin"
close "wp" or "oldwin".
- Fix splitting the wrong window if autocommands fired from switching to
"targetwin" switch to a different window.
- Ensure -1 is returned for all errors.
Also handle allocation failure a bit earlier in make_snapshot (callers,
except win_splitmove, don't really care if a snapshot can't be made, so
just ignore the return value).
Note: Test_smoothscroll_in_zero_width_window failed after these changes with
E36, as it was using the previous behaviour to create a zero-width window.
I've fixed the test such that it fails with UBSAN as expected when v9.0.1367 is
reverted (and simplified it too).
related: #14042
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 20 Feb 2024 22:30:04 +0100 |
parents | 360f286b5869 |
children |
line wrap: on
line source
" tests for 'langmap' source check.vim CheckFeature langmap func Test_langmap() new set langmap=}l,^x,%v call setline(1, ['abc']) call feedkeys('gg0}^', 'tx') call assert_equal('ac', getline(1)) " in Replace mode " need silent! to avoid a delay when entering Insert mode call setline(1, ['abcde']) silent! call feedkeys("gg0lR%{z\<Esc>00", 'tx') call assert_equal('a%{ze', getline(1)) " in Select mode " need silent! to avoid a delay when entering Insert mode call setline(1, ['abcde']) silent! call feedkeys("gg0}%}\<C-G>}^\<Esc>00", 'tx') call assert_equal('a}^de', getline(1)) " Error cases call assert_fails('set langmap=aA,b', 'E357:') call assert_fails('set langmap=z;y;y;z', 'E358:') " Map character > 256 enew! set langmap=āx,ăl,āx call setline(1, ['abcde']) call feedkeys('gg2lā', 'tx') call assert_equal('abde', getline(1)) " special characters in langmap enew! call setline(1, ['Hello World']) set langmap=\\;\\,,\\,\\; call feedkeys('ggfo,', 'tx') call assert_equal(8, col('.')) call feedkeys(';', 'tx') call assert_equal(5, col('.')) set langmap& set langmap=\\;\\,;\\,\\; call feedkeys('ggfo,', 'tx') call assert_equal(8, col('.')) call feedkeys(';', 'tx') call assert_equal(5, col('.')) set langmap=RL let g:counter = 0 nnoremap L;L <Cmd>let g:counter += 1<CR> nnoremap <C-L> <Cmd>throw 'This mapping should not be triggered'<CR> " 'langmap' is applied to keys without modifiers when matching a mapping call feedkeys('R;R', 'tx') call assert_equal(1, g:counter) nunmap L;L unlet g:counter delete call assert_equal('', getline(1)) undo call assert_equal('Hello World', getline(1)) " 'langmap' does not change Ctrl-R to Ctrl-L for consistency call feedkeys("\<*C-R>", 'tx') call assert_equal('', getline(1)) set langmap=6L undo setlocal bufhidden=hide let oldbuf = bufnr() enew call assert_notequal(oldbuf, bufnr()) " 'langmap' does not change Ctrl-6 to Ctrl-L for consistency " Ctrl-6 becomes Ctrl-^ after merging the Ctrl modifier call feedkeys("\<*C-6>", 'tx') call assert_equal(oldbuf, bufnr()) setlocal bufhidden& nunmap <C-L> set langmap& quit! endfunc " vim: shiftwidth=2 sts=2 expandtab