Mercurial > vim
view src/testdir/test_hlsearch.vim @ 34379:37b4c89ba420 v9.1.0116
patch 9.1.0116: win_split_ins may not check available room
Commit: https://github.com/vim/vim/commit/0fd44a5ad81ade342cb54d8984965bdedd2272c8
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Feb 20 20:28:15 2024 +0100
patch 9.1.0116: win_split_ins may not check available room
Problem: win_split_ins has no check for E36 when moving an existing
window
Solution: check for room and fix the issues in f_win_splitmove()
(Sean Dewar)
win_split_ins has no check for E36 when moving an existing window,
allowing for layouts with many overlapping zero-sized windows to be
created (which may also cause drawing issues with tablines and such).
f_win_splitmove also has some bugs.
So check for room and fix the issues in f_win_splitmove. Handle failure
in the two relevant win_split_ins callers by restoring the original
layout, and factor the common logic into win_splitmove.
Don't check for room when opening an autocommand window, as it's a
temporary window that's rarely interacted with or drawn anyhow, and is
rather important for some autocommands.
Issues fixed in f_win_splitmove:
- Error if splitting is disallowed.
- Fix heap-use-after-frees if autocommands fired from switching to "targetwin"
close "wp" or "oldwin".
- Fix splitting the wrong window if autocommands fired from switching to
"targetwin" switch to a different window.
- Ensure -1 is returned for all errors.
Also handle allocation failure a bit earlier in make_snapshot (callers,
except win_splitmove, don't really care if a snapshot can't be made, so
just ignore the return value).
Note: Test_smoothscroll_in_zero_width_window failed after these changes with
E36, as it was using the previous behaviour to create a zero-width window.
I've fixed the test such that it fails with UBSAN as expected when v9.0.1367 is
reverted (and simplified it too).
related: #14042
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 20 Feb 2024 22:30:04 +0100 |
parents | 695b50472e85 |
children |
line wrap: on
line source
" Test for v:hlsearch source check.vim source screendump.vim func Test_hlsearch() new call setline(1, repeat(['aaa'], 10)) set hlsearch nolazyredraw " redraw is needed to make hlsearch highlight the matches exe "normal! /aaa\<CR>" | redraw let r1 = screenattr(1, 1) nohlsearch | redraw call assert_notequal(r1, screenattr(1,1)) let v:hlsearch=1 | redraw call assert_equal(r1, screenattr(1,1)) let v:hlsearch=0 | redraw call assert_notequal(r1, screenattr(1,1)) set hlsearch | redraw call assert_equal(r1, screenattr(1,1)) let v:hlsearch=0 | redraw call assert_notequal(r1, screenattr(1,1)) exe "normal! n" | redraw call assert_equal(r1, screenattr(1,1)) let v:hlsearch=0 | redraw call assert_notequal(r1, screenattr(1,1)) exe "normal! /\<CR>" | redraw call assert_equal(r1, screenattr(1,1)) set nohls exe "normal! /\<CR>" | redraw call assert_notequal(r1, screenattr(1,1)) call assert_fails('let v:hlsearch=[]', 'E745:') call garbagecollect(1) call getchar(1) enew! endfunc func Test_hlsearch_hangs() CheckFunction reltimefloat " So, it turns out that Windows 7 implements TimerQueue timers differently " and they can expire *before* the requested time has elapsed. So allow for " the timeout occurring after 80 ms (5 * 16 (the typical clock tick)). if has("win32") let min_timeout = 0.08 else let min_timeout = 0.1 endif " This pattern takes a long time to match, it should timeout. new call setline(1, ['aaa', repeat('abc ', 1000), 'ccc']) let start = reltime() set hlsearch nolazyredraw redrawtime=101 let @/ = '\%#=1a*.*X\@<=b*' redraw let elapsed = reltimefloat(reltime(start)) call assert_inrange(min_timeout, 1.0, elapsed) set nohlsearch redrawtime& bwipe! endfunc func Test_hlsearch_eol_highlight() new call append(1, repeat([''], 9)) set hlsearch nolazyredraw exe "normal! /$\<CR>" | redraw let attr = screenattr(1, 1) for row in range(2, 10) call assert_equal(attr, screenattr(row, 1), 'in line ' . row) endfor set nohlsearch bwipe! endfunc func Test_hlsearch_Ctrl_R() CheckRunVimInTerminal let lines =<< trim END set incsearch hlsearch let @" = "text" put END call writefile(lines, 'XhlsearchCtrlR', 'D') let buf = RunVimInTerminal('-S XhlsearchCtrlR', #{rows: 6, cols: 60}) call term_sendkeys(buf, "/\<C-R>\<C-R>\"") call VerifyScreenDump(buf, 'Test_hlsearch_ctrlr_1', {}) call term_sendkeys(buf, "\<Esc>") call StopVimInTerminal(buf) endfunc func Test_hlsearch_clipboard() CheckRunVimInTerminal CheckFeature clipboard_working let lines =<< trim END set incsearch hlsearch let @* = "text" put * END call writefile(lines, 'XhlsearchClipboard', 'D') let buf = RunVimInTerminal('-S XhlsearchClipboard', #{rows: 6, cols: 60}) call term_sendkeys(buf, "/\<C-R>*") call VerifyScreenDump(buf, 'Test_hlsearch_ctrlr_1', {}) call term_sendkeys(buf, "\<Esc>") call StopVimInTerminal(buf) endfunc " vim: shiftwidth=2 sts=2 expandtab