Mercurial > vim
view src/testdir/test_global.vim @ 34379:37b4c89ba420 v9.1.0116
patch 9.1.0116: win_split_ins may not check available room
Commit: https://github.com/vim/vim/commit/0fd44a5ad81ade342cb54d8984965bdedd2272c8
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Feb 20 20:28:15 2024 +0100
patch 9.1.0116: win_split_ins may not check available room
Problem: win_split_ins has no check for E36 when moving an existing
window
Solution: check for room and fix the issues in f_win_splitmove()
(Sean Dewar)
win_split_ins has no check for E36 when moving an existing window,
allowing for layouts with many overlapping zero-sized windows to be
created (which may also cause drawing issues with tablines and such).
f_win_splitmove also has some bugs.
So check for room and fix the issues in f_win_splitmove. Handle failure
in the two relevant win_split_ins callers by restoring the original
layout, and factor the common logic into win_splitmove.
Don't check for room when opening an autocommand window, as it's a
temporary window that's rarely interacted with or drawn anyhow, and is
rather important for some autocommands.
Issues fixed in f_win_splitmove:
- Error if splitting is disallowed.
- Fix heap-use-after-frees if autocommands fired from switching to "targetwin"
close "wp" or "oldwin".
- Fix splitting the wrong window if autocommands fired from switching to
"targetwin" switch to a different window.
- Ensure -1 is returned for all errors.
Also handle allocation failure a bit earlier in make_snapshot (callers,
except win_splitmove, don't really care if a snapshot can't be made, so
just ignore the return value).
Note: Test_smoothscroll_in_zero_width_window failed after these changes with
E36, as it was using the previous behaviour to create a zero-width window.
I've fixed the test such that it fails with UBSAN as expected when v9.0.1367 is
reverted (and simplified it too).
related: #14042
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 20 Feb 2024 22:30:04 +0100 |
parents | 0e92ffdd9ea7 |
children | 759436dfc8ac |
line wrap: on
line source
" Test for :global and :vglobal source check.vim source term_util.vim func Test_yank_put_clipboard() new call setline(1, ['a', 'b', 'c']) set clipboard=unnamed g/^/normal yyp call assert_equal(['a', 'a', 'b', 'b', 'c', 'c'], getline(1, 6)) set clipboard=unnamed,unnamedplus call setline(1, ['a', 'b', 'c']) g/^/normal yyp call assert_equal(['a', 'a', 'b', 'b', 'c', 'c'], getline(1, 6)) set clipboard& bwipe! endfunc func Test_global_set_clipboard() CheckFeature clipboard_working new set clipboard=unnamedplus let @+='clipboard' | g/^/set cb= | let @" = 'unnamed' | put call assert_equal(['','unnamed'], getline(1, '$')) set clipboard& bwipe! endfunc func Test_nested_global() new call setline(1, ['nothing', 'found', 'found bad', 'bad']) call assert_fails('g/found/3v/bad/s/^/++/', 'E147:') g/found/v/bad/s/^/++/ call assert_equal(['nothing', '++found', 'found bad', 'bad'], getline(1, 4)) bwipe! endfunc func Test_global_error() call assert_fails('g\\a', 'E10:') call assert_fails('g', 'E148:') call assert_fails('g/\(/y', 'E54:') endfunc " Test for printing lines using :g with different search patterns func Test_global_print() new call setline(1, ['foo', 'bar', 'foo', 'foo']) let @/ = 'foo' let t = execute("g/")->trim()->split("\n") call assert_equal(['foo', 'foo', 'foo'], t) " Test for Vi compatible patterns let @/ = 'bar' let t = execute('g\/')->trim()->split("\n") call assert_equal(['bar'], t) normal gg s/foo/foo/ let t = execute('g\&')->trim()->split("\n") call assert_equal(['foo', 'foo', 'foo'], t) let @/ = 'bar' let t = execute('g?')->trim()->split("\n") call assert_equal(['bar'], t) " Test for the 'Pattern found in every line' message let v:statusmsg = '' v/foo\|bar/p call assert_notequal('', v:statusmsg) " In Vim9 script this is an error let caught = 'no' try vim9cmd v/foo\|bar/p catch /E538/ let caught = 'yes' call assert_match('E538: Pattern found in every line: foo\|bar', v:exception) endtry call assert_equal('yes', caught) " In Vim9 script not matching is an error let caught = 'no' try vim9cmd g/foobarnotfound/p catch /E486/ let caught = 'yes' call assert_match('E486: Pattern not found: foobarnotfound', v:exception) endtry call assert_equal('yes', caught) close! endfunc func Test_global_empty_pattern() " populate history silent g/hello/ redir @a g// redir END call assert_match('Pattern not found: hello', @a) " ^~~~~ this was previously empty endfunc " Test for global command with newline character func Test_global_newline() new call setline(1, ['foo']) exe "g/foo/s/f/h/\<NL>s/o$/w/" call assert_equal('how', getline(1)) call setline(1, ["foo\<NL>bar"]) exe "g/foo/s/foo\\\<NL>bar/xyz/" call assert_equal('xyz', getline(1)) close! endfunc func Test_wrong_delimiter() call assert_fails('g x^bxd', 'E146:') endfunc " Test for interrupting :global using Ctrl-C func Test_interrupt_global() CheckRunVimInTerminal let lines =<< trim END cnoremap ; <Cmd>sleep 10<CR> call setline(1, repeat(['foo'], 5)) END call writefile(lines, 'Xtest_interrupt_global', 'D') let buf = RunVimInTerminal('-S Xtest_interrupt_global', {'rows': 6}) call term_sendkeys(buf, ":g/foo/norm :\<C-V>;\<CR>") " Wait for :sleep to start call TermWait(buf, 100) call term_sendkeys(buf, "\<C-C>") call WaitForAssert({-> assert_match('Interrupted', term_getline(buf, 6))}, 1000) " Also test in Ex mode call term_sendkeys(buf, "gQg/foo/norm :\<C-V>;\<CR>") " Wait for :sleep to start call TermWait(buf, 100) call term_sendkeys(buf, "\<C-C>") call WaitForAssert({-> assert_match('Interrupted', term_getline(buf, 5))}, 1000) call StopVimInTerminal(buf) endfunc " vim: shiftwidth=2 sts=2 expandtab