Mercurial > vim
view src/testdir/test_function_lists.vim @ 34379:37b4c89ba420 v9.1.0116
patch 9.1.0116: win_split_ins may not check available room
Commit: https://github.com/vim/vim/commit/0fd44a5ad81ade342cb54d8984965bdedd2272c8
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Feb 20 20:28:15 2024 +0100
patch 9.1.0116: win_split_ins may not check available room
Problem: win_split_ins has no check for E36 when moving an existing
window
Solution: check for room and fix the issues in f_win_splitmove()
(Sean Dewar)
win_split_ins has no check for E36 when moving an existing window,
allowing for layouts with many overlapping zero-sized windows to be
created (which may also cause drawing issues with tablines and such).
f_win_splitmove also has some bugs.
So check for room and fix the issues in f_win_splitmove. Handle failure
in the two relevant win_split_ins callers by restoring the original
layout, and factor the common logic into win_splitmove.
Don't check for room when opening an autocommand window, as it's a
temporary window that's rarely interacted with or drawn anyhow, and is
rather important for some autocommands.
Issues fixed in f_win_splitmove:
- Error if splitting is disallowed.
- Fix heap-use-after-frees if autocommands fired from switching to "targetwin"
close "wp" or "oldwin".
- Fix splitting the wrong window if autocommands fired from switching to
"targetwin" switch to a different window.
- Ensure -1 is returned for all errors.
Also handle allocation failure a bit earlier in make_snapshot (callers,
except win_splitmove, don't really care if a snapshot can't be made, so
just ignore the return value).
Note: Test_smoothscroll_in_zero_width_window failed after these changes with
E36, as it was using the previous behaviour to create a zero-width window.
I've fixed the test such that it fails with UBSAN as expected when v9.0.1367 is
reverted (and simplified it too).
related: #14042
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 20 Feb 2024 22:30:04 +0100 |
parents | a52697bcffa6 |
children |
line wrap: on
line source
" Test to verify that the three function lists: " " - global_functions[] in src/evalfunc.c " - *functions* in runtime/doc/builtin.txt " - *function-list* in runtime/doc/usr_41.txt " " contain the same functions and that the global_functions and " ":help functions" lists are in ASCII order. func Test_function_lists() " Delete any files left over from an earlier run of this test. call delete("Xglobal_functions.diff") call delete("Xfunctions.diff") call delete("Xfunction-list.diff") " Create a file of the functions in evalfunc.c:global_functions[]. enew! read ../evalfunc.c 1,/^static funcentry_T global_functions\[\] =$/d call search('^};$') .,$d v/^ {/d %s/^ {"// %s/".*// w! Xglobal_functions " Verify that those functions are in ASCII order. sort u w! Xsorted_global_functions let l:unequal = assert_equalfile("Xsorted_global_functions", "Xglobal_functions", \ "global_functions[] not sorted") if l:unequal && executable("diff") call system("diff -u Xsorted_global_functions Xglobal_functions > Xglobal_functions.diff") endif " Create a file of the functions in evalfunc.c:global_functions[] that are " not obsolete, sorted in ASCII order. enew! read ../evalfunc.c 1,/^static funcentry_T global_functions\[\] =$/d call search('^};$') .,$d v/^ {/d g/\/\/ obsolete$/d %s/^ {"// %s/".*// sort u w! ++ff=unix Xsorted_current_global_functions " Verify that the ":help functions" list is complete and in ASCII order. enew! if filereadable('../../doc/builtin.txt') " unpacked MS-Windows zip archive read ../../doc/builtin.txt else read ../../runtime/doc/builtin.txt endif call search('^USAGE') 1,.d call search('^==========') .,$d v/^\S/d %s/(.*// let l:lines = getline(1, '$') call uniq(l:lines) call writefile(l:lines, "Xfunctions") let l:unequal = assert_equalfile("Xsorted_current_global_functions", "Xfunctions", \ "\":help functions\" not sorted or incomplete") if l:unequal && executable("diff") call system("diff -u Xsorted_current_global_functions Xfunctions > Xfunctions.diff") endif " Verify that the ":help function-list" list is complete. enew! if filereadable('../../doc/usr_41.txt') " unpacked MS-Windows zip archive read ../../doc/usr_41.txt else read ../../runtime/doc/usr_41.txt endif call search('\*function-list\*$') 1,.d call search('^==*$') .,$d v/^\t\S/d %s/(.*// %left sort u w! ++ff=unix Xfunction-list let l:unequal = assert_equalfile("Xsorted_current_global_functions", "Xfunction-list", \ "\":help function-list\" incomplete") if l:unequal && executable("diff") call system("diff -u Xsorted_current_global_functions Xfunction-list > Xfunction-list.diff") endif " Clean up. call delete("Xglobal_functions") call delete("Xsorted_global_functions") call delete("Xsorted_current_global_functions") call delete("Xfunctions") call delete("Xfunction-list") enew! endfunc " vim: shiftwidth=2 sts=2 expandtab