Mercurial > vim
view src/testdir/test_flatten.vim @ 34379:37b4c89ba420 v9.1.0116
patch 9.1.0116: win_split_ins may not check available room
Commit: https://github.com/vim/vim/commit/0fd44a5ad81ade342cb54d8984965bdedd2272c8
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Feb 20 20:28:15 2024 +0100
patch 9.1.0116: win_split_ins may not check available room
Problem: win_split_ins has no check for E36 when moving an existing
window
Solution: check for room and fix the issues in f_win_splitmove()
(Sean Dewar)
win_split_ins has no check for E36 when moving an existing window,
allowing for layouts with many overlapping zero-sized windows to be
created (which may also cause drawing issues with tablines and such).
f_win_splitmove also has some bugs.
So check for room and fix the issues in f_win_splitmove. Handle failure
in the two relevant win_split_ins callers by restoring the original
layout, and factor the common logic into win_splitmove.
Don't check for room when opening an autocommand window, as it's a
temporary window that's rarely interacted with or drawn anyhow, and is
rather important for some autocommands.
Issues fixed in f_win_splitmove:
- Error if splitting is disallowed.
- Fix heap-use-after-frees if autocommands fired from switching to "targetwin"
close "wp" or "oldwin".
- Fix splitting the wrong window if autocommands fired from switching to
"targetwin" switch to a different window.
- Ensure -1 is returned for all errors.
Also handle allocation failure a bit earlier in make_snapshot (callers,
except win_splitmove, don't really care if a snapshot can't be made, so
just ignore the return value).
Note: Test_smoothscroll_in_zero_width_window failed after these changes with
E36, as it was using the previous behaviour to create a zero-width window.
I've fixed the test such that it fails with UBSAN as expected when v9.0.1367 is
reverted (and simplified it too).
related: #14042
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 20 Feb 2024 22:30:04 +0100 |
parents | 18319c0c36f9 |
children |
line wrap: on
line source
" Test for flatting list. func Test_flatten() call assert_fails('call flatten(1)', 'E686:') call assert_fails('call flatten({})', 'E686:') call assert_fails('call flatten("string")', 'E686:') call assert_fails('call flatten([], [])', 'E745:') call assert_fails('call flatten([], -1)', 'E900: maxdepth') call assert_equal([], flatten([])) call assert_equal([], flatten([[]])) call assert_equal([], flatten([[[]]])) call assert_equal([1, 2, 3], flatten([1, 2, 3])) call assert_equal([1, 2, 3], flatten([[1], 2, 3])) call assert_equal([1, 2, 3], flatten([1, [2], 3])) call assert_equal([1, 2, 3], flatten([1, 2, [3]])) call assert_equal([1, 2, 3], flatten([[1], [2], 3])) call assert_equal([1, 2, 3], flatten([1, [2], [3]])) call assert_equal([1, 2, 3], flatten([[1], 2, [3]])) call assert_equal([1, 2, 3], flatten([[1], [2], [3]])) call assert_equal([1, 2, 3], flatten([[1, 2, 3], []])) call assert_equal([1, 2, 3], flatten([[], [1, 2, 3]])) call assert_equal([1, 2, 3], flatten([[1, 2], [], [3]])) call assert_equal([1, 2, 3], flatten([[], [1, 2, 3], []])) call assert_equal([1, 2, 3, 4], flatten(range(1, 4))) " example in the help call assert_equal([1, 2, 3, 4, 5], flatten([1, [2, [3, 4]], 5])) call assert_equal([1, 2, [3, 4], 5], flatten([1, [2, [3, 4]], 5], 1)) call assert_equal([0, [1], 2, [3], 4], flatten([[0, [1]], 2, [[3], 4]], 1)) call assert_equal([1, 2, 3], flatten([[[[1]]], [2], [3]], 3)) call assert_equal([[1], [2], [3]], flatten([[[1], [2], [3]]], 1)) call assert_equal([[1]], flatten([[1]], 0)) " Make it flatten if the given maxdepth is larger than actual depth. call assert_equal([1, 2, 3], flatten([[1, 2, 3]], 1)) call assert_equal([1, 2, 3], flatten([[1, 2, 3]], 2)) let l:list = [[1], [2], [3]] call assert_equal([1, 2, 3], flatten(l:list)) call assert_equal([1, 2, 3], l:list) " Tests for checking reference counter works well. let l:x = {'foo': 'bar'} call assert_equal([1, 2, l:x, 3], flatten([1, [2, l:x], 3])) call test_garbagecollect_now() call assert_equal('bar', l:x.foo) let l:list = [[1], [2], [3]] call assert_equal([1, 2, 3], flatten(l:list)) call test_garbagecollect_now() call assert_equal([1, 2, 3], l:list) " Tests for checking circular reference list can be flattened. let l:x = [1] let l:y = [x] let l:z = flatten(l:y) call assert_equal([1], l:z) call test_garbagecollect_now() let l:x[0] = 2 call assert_equal([2], l:x) call assert_equal([1], l:z) " NOTE: primitive types are copied. call assert_equal([1], l:y) let l:x = [2] let l:y = [1, [l:x], 3] " [1, [[2]], 3] let l:z = flatten(l:y, 1) call assert_equal([1, [2], 3], l:z) let l:x[0] = 9 call assert_equal([1, [9], 3], l:z) " Reference to l:x is kept. call assert_equal([1, [9], 3], l:y) let l:x = [1] let l:y = [2] call add(x, y) " l:x = [1, [2]] call add(y, x) " l:y = [2, [1, [...]]] call assert_equal([1, 2, 1, 2], flatten(l:x, 2)) call assert_equal([2, l:x], l:y) let l4 = [ 1, [ 11, [ 101, [ 1001 ] ] ] ] call assert_equal(l4, flatten(deepcopy(l4), 0)) call assert_equal([1, 11, [101, [1001]]], flatten(deepcopy(l4), 1)) call assert_equal([1, 11, 101, [1001]], flatten(deepcopy(l4), 2)) call assert_equal([1, 11, 101, 1001], flatten(deepcopy(l4), 3)) call assert_equal([1, 11, 101, 1001], flatten(deepcopy(l4), 4)) call assert_equal([1, 11, 101, 1001], flatten(deepcopy(l4))) endfunc func Test_flattennew() let l = [1, [2, [3, 4]], 5] call assert_equal([1, 2, 3, 4, 5], flattennew(l)) call assert_equal([1, [2, [3, 4]], 5], l) call assert_equal([1, 2, [3, 4], 5], flattennew(l, 1)) call assert_equal([1, [2, [3, 4]], 5], l) let l4 = [ 1, [ 11, [ 101, [ 1001 ] ] ] ] call assert_equal(l4, flatten(deepcopy(l4), 0)) call assert_equal([1, 11, [101, [1001]]], flattennew(l4, 1)) call assert_equal([1, 11, 101, [1001]], flattennew(l4, 2)) call assert_equal([1, 11, 101, 1001], flattennew(l4, 3)) call assert_equal([1, 11, 101, 1001], flattennew(l4, 4)) call assert_equal([1, 11, 101, 1001], flattennew(l4)) endfunc " vim: shiftwidth=2 sts=2 expandtab