Mercurial > vim
view src/testdir/test_ex_z.vim @ 34379:37b4c89ba420 v9.1.0116
patch 9.1.0116: win_split_ins may not check available room
Commit: https://github.com/vim/vim/commit/0fd44a5ad81ade342cb54d8984965bdedd2272c8
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Feb 20 20:28:15 2024 +0100
patch 9.1.0116: win_split_ins may not check available room
Problem: win_split_ins has no check for E36 when moving an existing
window
Solution: check for room and fix the issues in f_win_splitmove()
(Sean Dewar)
win_split_ins has no check for E36 when moving an existing window,
allowing for layouts with many overlapping zero-sized windows to be
created (which may also cause drawing issues with tablines and such).
f_win_splitmove also has some bugs.
So check for room and fix the issues in f_win_splitmove. Handle failure
in the two relevant win_split_ins callers by restoring the original
layout, and factor the common logic into win_splitmove.
Don't check for room when opening an autocommand window, as it's a
temporary window that's rarely interacted with or drawn anyhow, and is
rather important for some autocommands.
Issues fixed in f_win_splitmove:
- Error if splitting is disallowed.
- Fix heap-use-after-frees if autocommands fired from switching to "targetwin"
close "wp" or "oldwin".
- Fix splitting the wrong window if autocommands fired from switching to
"targetwin" switch to a different window.
- Ensure -1 is returned for all errors.
Also handle allocation failure a bit earlier in make_snapshot (callers,
except win_splitmove, don't really care if a snapshot can't be made, so
just ignore the return value).
Note: Test_smoothscroll_in_zero_width_window failed after these changes with
E36, as it was using the previous behaviour to create a zero-width window.
I've fixed the test such that it fails with UBSAN as expected when v9.0.1367 is
reverted (and simplified it too).
related: #14042
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 20 Feb 2024 22:30:04 +0100 |
parents | 0f93e9423890 |
children |
line wrap: on
line source
" Test :z func Test_z() call setline(1, range(1, 100)) let a = execute('20z3') call assert_equal("\n20\n21\n22", a) call assert_equal(22, line('.')) " 'window' should be set to the {count} value. call assert_equal(3, &window) " If there is only one window, then twice the amount of 'scroll' is used. set scroll=2 let a = execute('20z') call assert_equal("\n20\n21\n22\n23", a) call assert_equal(23, line('.')) let a = execute('20z+3') " FIXME: I would expect the same result as '20z3' since 'help z' " says: Specifying no mark at all is the same as "+". " However it " gives "\n21\n22\n23" instead. Bug in Vim or in ":help :z"? "call assert_equal("\n20\n21\n22", a) "call assert_equal(22, line('.')) let a = execute('20z-3') call assert_equal("\n18\n19\n20", a) call assert_equal(20, line('.')) let a = execute('20z=3') call assert_match("^\n18\n19\n-\\+\n20\n-\\+\n21\n22$", a) call assert_equal(20, line('.')) let a = execute('20z^3') call assert_equal("\n14\n15\n16\n17", a) call assert_equal(17, line('.')) let a = execute('20z.3') call assert_equal("\n19\n20\n21", a) call assert_equal(21, line('.')) let a = execute('20z#3') call assert_equal("\n 20 20\n 21 21\n 22 22", a) call assert_equal(22, line('.')) let a = execute('20z#-3') call assert_equal("\n 18 18\n 19 19\n 20 20", a) call assert_equal(20, line('.')) let a = execute('20z#=3') call assert_match("^\n 18 18\n 19 19\n-\\+\n 20 20\n-\\+\n 21 21\n 22 22$", a) call assert_equal(20, line('.')) " Test with {count} bigger than the number of lines in buffer. let a = execute('20z1000') call assert_match("^\n20\n21\n.*\n99\n100$", a) call assert_equal(100, line('.')) let a = execute('20z-1000') call assert_equal(20, line('.')) let a = execute('20z=1000') call assert_match("^\n1\n.*\n-\\+\n20\n-\\\+\n.*\n100$", a) call assert_equal(20, line('.')) " Tests with multiple windows. 5split call setline(1, range(1, 100)) " Without a count, the number line is window height - 3. let a = execute('20z') call assert_equal("\n20\n21", a) call assert_equal(21, line('.')) " If window height - 3 is less than 1, it should be clamped to 1. resize 2 let a = execute('20z') call assert_equal("\n20", a) call assert_equal(20, line('.')) call assert_fails('20z=a', 'E144:') set window& scroll& bw! endfunc " :z! is the same as :z but count uses the Vim window height when not specified. func Test_z_bang() 4split call setline(1, range(1, 20)) let a = execute('10z!') call assert_equal("\n10\n11\n12\n13\n14\n15\n16\n17\n18\n19\n20", a) let a = execute('10z!#') call assert_equal("\n 10 10\n 11 11\n 12 12\n 13 13\n 14 14\n 15 15\n 16 16\n 17 17\n 18 18\n 19 19\n 20 20", a) let a = execute('10z!3') call assert_equal("\n10\n11\n12", a) %bwipe! endfunc func Test_z_overflow() " This used to access invalid memory as a result of an integer overflow " and freeze vim. normal ox normal Heat z777777776666666 ') endfunc func Test_z_negative_lnum() new z^ call assert_equal(1, line('.')) bwipe! endfunc " vim: shiftwidth=2 sts=2 expandtab