Mercurial > vim
view src/testdir/test_environ.vim @ 34379:37b4c89ba420 v9.1.0116
patch 9.1.0116: win_split_ins may not check available room
Commit: https://github.com/vim/vim/commit/0fd44a5ad81ade342cb54d8984965bdedd2272c8
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Feb 20 20:28:15 2024 +0100
patch 9.1.0116: win_split_ins may not check available room
Problem: win_split_ins has no check for E36 when moving an existing
window
Solution: check for room and fix the issues in f_win_splitmove()
(Sean Dewar)
win_split_ins has no check for E36 when moving an existing window,
allowing for layouts with many overlapping zero-sized windows to be
created (which may also cause drawing issues with tablines and such).
f_win_splitmove also has some bugs.
So check for room and fix the issues in f_win_splitmove. Handle failure
in the two relevant win_split_ins callers by restoring the original
layout, and factor the common logic into win_splitmove.
Don't check for room when opening an autocommand window, as it's a
temporary window that's rarely interacted with or drawn anyhow, and is
rather important for some autocommands.
Issues fixed in f_win_splitmove:
- Error if splitting is disallowed.
- Fix heap-use-after-frees if autocommands fired from switching to "targetwin"
close "wp" or "oldwin".
- Fix splitting the wrong window if autocommands fired from switching to
"targetwin" switch to a different window.
- Ensure -1 is returned for all errors.
Also handle allocation failure a bit earlier in make_snapshot (callers,
except win_splitmove, don't really care if a snapshot can't be made, so
just ignore the return value).
Note: Test_smoothscroll_in_zero_width_window failed after these changes with
E36, as it was using the previous behaviour to create a zero-width window.
I've fixed the test such that it fails with UBSAN as expected when v9.0.1367 is
reverted (and simplified it too).
related: #14042
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 20 Feb 2024 22:30:04 +0100 |
parents | e3ab1d0f2ef9 |
children |
line wrap: on
line source
" Test for environment variables. scriptencoding utf-8 source check.vim func Test_environ() unlet! $TESTENV call assert_equal(0, has_key(environ(), 'TESTENV')) let $TESTENV = 'foo' call assert_equal(1, has_key(environ(), 'TESTENV')) let $TESTENV = 'こんにちわ' call assert_equal('こんにちわ', environ()['TESTENV']) endfunc func Test_getenv() unlet! $TESTENV call assert_equal(v:null, 'TESTENV'->getenv()) let $TESTENV = 'foo' call assert_equal('foo', getenv('TESTENV')) endfunc func Test_setenv() unlet! $TESTENV eval 'foo'->setenv('TEST ENV') call assert_equal('foo', getenv('TEST ENV')) call setenv('TEST ENV', v:null) call assert_equal(v:null, getenv('TEST ENV')) endfunc func Test_special_env() " The value for $HOME is cached internally by Vim, ensure the value is up to " date. let orig_ENV = $HOME let $HOME = 'foo' call assert_equal('foo', expand('~')) " old $HOME value is kept until a new one is set unlet $HOME call assert_equal('foo', expand('~')) call setenv('HOME', 'bar') call assert_equal('bar', expand('~')) " old $HOME value is kept until a new one is set call setenv('HOME', v:null) call assert_equal('bar', expand('~')) let $HOME = orig_ENV endfunc func Test_external_env() call setenv('FOO', 'HelloWorld') if has('win32') let result = system('echo %FOO%') else let result = system('echo $FOO') endif let result = substitute(result, '[ \r\n]', '', 'g') call assert_equal('HelloWorld', result) call setenv('FOO', v:null) if has('win32') let result = system('set | findstr "^FOO="') else let result = system('env | grep ^FOO=') endif call assert_equal('', result) endfunc func Test_mac_locale() CheckFeature osxdarwin " If $LANG is not set then the system locale will be used. " Run Vim after unsetting all the locale environmental vars, and capture the " output of :lang. let lang_results = system("unset LANG; unset LC_MESSAGES; unset LC_CTYPE; " .. \ shellescape(v:progpath) .. \ " --clean -esX -c 'redir @a' -c 'lang' -c 'put a' -c 'print' -c 'qa!' ") " Check that: " 1. The locale is the form of <locale>.UTF-8. " 2. Check that fourth item (LC_NUMERIC) is properly set to "C". " Example match: "en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8" call assert_match('"\([a-zA-Z_]\+\.UTF-8/\)\{3}C\(/[a-zA-Z_]\+\.UTF-8\)\{2}"', \ lang_results, \ "Default locale should have UTF-8 encoding set, and LC_NUMERIC set to 'C'") endfunc " vim: shiftwidth=2 sts=2 expandtab