Mercurial > vim
view src/testdir/test_charsearch.vim @ 34379:37b4c89ba420 v9.1.0116
patch 9.1.0116: win_split_ins may not check available room
Commit: https://github.com/vim/vim/commit/0fd44a5ad81ade342cb54d8984965bdedd2272c8
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Feb 20 20:28:15 2024 +0100
patch 9.1.0116: win_split_ins may not check available room
Problem: win_split_ins has no check for E36 when moving an existing
window
Solution: check for room and fix the issues in f_win_splitmove()
(Sean Dewar)
win_split_ins has no check for E36 when moving an existing window,
allowing for layouts with many overlapping zero-sized windows to be
created (which may also cause drawing issues with tablines and such).
f_win_splitmove also has some bugs.
So check for room and fix the issues in f_win_splitmove. Handle failure
in the two relevant win_split_ins callers by restoring the original
layout, and factor the common logic into win_splitmove.
Don't check for room when opening an autocommand window, as it's a
temporary window that's rarely interacted with or drawn anyhow, and is
rather important for some autocommands.
Issues fixed in f_win_splitmove:
- Error if splitting is disallowed.
- Fix heap-use-after-frees if autocommands fired from switching to "targetwin"
close "wp" or "oldwin".
- Fix splitting the wrong window if autocommands fired from switching to
"targetwin" switch to a different window.
- Ensure -1 is returned for all errors.
Also handle allocation failure a bit earlier in make_snapshot (callers,
except win_splitmove, don't really care if a snapshot can't be made, so
just ignore the return value).
Note: Test_smoothscroll_in_zero_width_window failed after these changes with
E36, as it was using the previous behaviour to create a zero-width window.
I've fixed the test such that it fails with UBSAN as expected when v9.0.1367 is
reverted (and simplified it too).
related: #14042
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 20 Feb 2024 22:30:04 +0100 |
parents | 695b50472e85 |
children |
line wrap: on
line source
" Test for character search commands - t, T, f, F, ; and , func Test_charsearch() enew! call append(0, ['Xabcdefghijkemnopqretuvwxyz', \ 'Yabcdefghijkemnopqretuvwxyz', \ 'Zabcdefghijkemnokqretkvwxyz']) " check that "fe" and ";" work 1 normal! ylfep;;p,,p call assert_equal('XabcdeXfghijkeXmnopqreXtuvwxyz', getline(1)) " check that save/restore works 2 normal! ylfep let csave = getcharsearch() normal! fip call setcharsearch(csave) normal! ;p;p call assert_equal('YabcdeYfghiYjkeYmnopqreYtuvwxyz', getline(2)) " check that setcharsearch() changes the settings. 3 normal! ylfep eval {'char': 'k'}->setcharsearch() normal! ;p call setcharsearch({'forward': 0}) normal! $;p call setcharsearch({'until': 1}) set cpo-=; normal! ;;p call assert_equal('ZabcdeZfghijkZZemnokqretkZvwxyz', getline(3)) " check that repeating a search before and after a line fails normal 3Gfv call assert_beeps('normal ;') call assert_beeps('normal ,') " clear the character search call setcharsearch({'char' : ''}) call assert_equal('', getcharsearch().char) call assert_beeps('normal ;') call assert_beeps('normal ,') call assert_fails("call setcharsearch([])", 'E1206:') enew! endfunc " Test for character search in virtual edit mode with <Tab> func Test_csearch_virtualedit() new set virtualedit=all call setline(1, "a\tb") normal! tb call assert_equal([0, 1, 2, 6], getpos('.')) set virtualedit& bw! endfunc " Test for character search failure in latin1 encoding func Test_charsearch_latin1() new let save_enc = &encoding set encoding=latin1 call setline(1, 'abcdefghijk') call assert_beeps('normal fz') call assert_beeps('normal tx') call assert_beeps('normal $Fz') call assert_beeps('normal $Tx') let &encoding = save_enc bw! endfunc " Test for using character search to find a multibyte character with composing " characters. func Test_charsearch_composing_char() new call setline(1, "one two thq\u0328\u0301r\u0328\u0301ree") call feedkeys("fr\u0328\u0301", 'xt') call assert_equal([0, 1, 16, 0, 12], getcurpos()) " use character search with a multi-byte character followed by a " non-composing character call setline(1, "abc deȉf ghi") call feedkeys("ggcf\u0209\u0210", 'xt') call assert_equal("\u0210f ghi", getline(1)) bw! endfunc " Test for character search with 'hkmap' func Test_charsearch_hkmap() new set hkmap call setline(1, "ùðáâ÷ëòéïçìêöî") call feedkeys("fë", 'xt') call assert_equal([0, 1, 11, 0, 6], getcurpos()) set hkmap& bw! endfunc " vim: shiftwidth=2 sts=2 expandtab