Mercurial > vim
view src/testdir/test_channel_pipe.py @ 34379:37b4c89ba420 v9.1.0116
patch 9.1.0116: win_split_ins may not check available room
Commit: https://github.com/vim/vim/commit/0fd44a5ad81ade342cb54d8984965bdedd2272c8
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Feb 20 20:28:15 2024 +0100
patch 9.1.0116: win_split_ins may not check available room
Problem: win_split_ins has no check for E36 when moving an existing
window
Solution: check for room and fix the issues in f_win_splitmove()
(Sean Dewar)
win_split_ins has no check for E36 when moving an existing window,
allowing for layouts with many overlapping zero-sized windows to be
created (which may also cause drawing issues with tablines and such).
f_win_splitmove also has some bugs.
So check for room and fix the issues in f_win_splitmove. Handle failure
in the two relevant win_split_ins callers by restoring the original
layout, and factor the common logic into win_splitmove.
Don't check for room when opening an autocommand window, as it's a
temporary window that's rarely interacted with or drawn anyhow, and is
rather important for some autocommands.
Issues fixed in f_win_splitmove:
- Error if splitting is disallowed.
- Fix heap-use-after-frees if autocommands fired from switching to "targetwin"
close "wp" or "oldwin".
- Fix splitting the wrong window if autocommands fired from switching to
"targetwin" switch to a different window.
- Ensure -1 is returned for all errors.
Also handle allocation failure a bit earlier in make_snapshot (callers,
except win_splitmove, don't really care if a snapshot can't be made, so
just ignore the return value).
Note: Test_smoothscroll_in_zero_width_window failed after these changes with
E36, as it was using the previous behaviour to create a zero-width window.
I've fixed the test such that it fails with UBSAN as expected when v9.0.1367 is
reverted (and simplified it too).
related: #14042
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 20 Feb 2024 22:30:04 +0100 |
parents | 06e3c6bac36d |
children |
line wrap: on
line source
#!/usr/bin/python # # Server that will communicate over stdin/stderr # # This requires Python 2.6 or later. from __future__ import print_function import os import sys import time if __name__ == "__main__": if len(sys.argv) > 1: if sys.argv[1].startswith("err"): print(sys.argv[1], file=sys.stderr) sys.stderr.flush() elif sys.argv[1].startswith("incomplete"): print(sys.argv[1], end='') sys.stdout.flush() sys.exit(0) elif sys.argv[1].startswith("busy"): time.sleep(100) sys.exit(0) else: print(sys.argv[1]) sys.stdout.flush() if sys.argv[1].startswith("quit"): sys.exit(0) if os.getenv('CI'): try: import thread_util thread_util.set_high_priority() except Exception: pass while True: typed = sys.stdin.readline() if typed == "": # EOF -- stop break if typed.startswith("quit"): print("Goodbye!") sys.stdout.flush() break if typed.startswith("echo "): print(typed[5:-1]) sys.stdout.flush() if typed.startswith("echosplit "): for part in typed[10:-1].split('|'): sys.stdout.write(part) sys.stdout.flush() time.sleep(0.05) if typed.startswith("double "): print(typed[7:-1] + "\nAND " + typed[7:-1]) sys.stdout.flush() if typed.startswith("split "): print(typed[6:-1], end='') sys.stdout.flush() time.sleep(0.05) print(typed[6:-1], end='') sys.stdout.flush() time.sleep(0.05) print(typed[6:-1]) sys.stdout.flush() if typed.startswith("echoerr "): print(typed[8:-1], file=sys.stderr) sys.stderr.flush() if typed.startswith("doubleerr "): print(typed[10:-1] + "\nAND " + typed[10:-1], file=sys.stderr) sys.stderr.flush() if typed.startswith("XXX"): print(typed, end='') sys.stderr.flush() break