Mercurial > vim
view src/testdir/setup_gui.vim @ 34379:37b4c89ba420 v9.1.0116
patch 9.1.0116: win_split_ins may not check available room
Commit: https://github.com/vim/vim/commit/0fd44a5ad81ade342cb54d8984965bdedd2272c8
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Feb 20 20:28:15 2024 +0100
patch 9.1.0116: win_split_ins may not check available room
Problem: win_split_ins has no check for E36 when moving an existing
window
Solution: check for room and fix the issues in f_win_splitmove()
(Sean Dewar)
win_split_ins has no check for E36 when moving an existing window,
allowing for layouts with many overlapping zero-sized windows to be
created (which may also cause drawing issues with tablines and such).
f_win_splitmove also has some bugs.
So check for room and fix the issues in f_win_splitmove. Handle failure
in the two relevant win_split_ins callers by restoring the original
layout, and factor the common logic into win_splitmove.
Don't check for room when opening an autocommand window, as it's a
temporary window that's rarely interacted with or drawn anyhow, and is
rather important for some autocommands.
Issues fixed in f_win_splitmove:
- Error if splitting is disallowed.
- Fix heap-use-after-frees if autocommands fired from switching to "targetwin"
close "wp" or "oldwin".
- Fix splitting the wrong window if autocommands fired from switching to
"targetwin" switch to a different window.
- Ensure -1 is returned for all errors.
Also handle allocation failure a bit earlier in make_snapshot (callers,
except win_splitmove, don't really care if a snapshot can't be made, so
just ignore the return value).
Note: Test_smoothscroll_in_zero_width_window failed after these changes with
E36, as it was using the previous behaviour to create a zero-width window.
I've fixed the test such that it fails with UBSAN as expected when v9.0.1367 is
reverted (and simplified it too).
related: #14042
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 20 Feb 2024 22:30:04 +0100 |
parents | 9849df834f1d |
children |
line wrap: on
line source
" Common preparations for running GUI tests. let g:x11_based_gui = has('gui_motif') \ || has('gui_gtk2') || has('gui_gnome') || has('gui_gtk3') " Reasons for 'skipped'. let g:not_supported = "Skipped: Feature/Option not supported by this GUI: " let g:not_hosted = "Skipped: Test not hosted by the system/environment" " For KDE set a font, empty 'guifont' may cause a hang. func GUISetUpCommon() if has("gui_kde") set guifont=Courier\ 10\ Pitch/8/-1/5/50/0/0/0/0/0 endif " Gnome insists on creating $HOME/.gnome2/, set $HOME to avoid changing the " actual home directory. But avoid triggering fontconfig by setting the " cache directory. Only needed for Unix. if $XDG_CACHE_HOME == '' && exists('g:tester_HOME') let $XDG_CACHE_HOME = g:tester_HOME . '/.cache' endif call mkdir('Xhome') let $HOME = fnamemodify('Xhome', ':p') endfunc func GUITearDownCommon() call delete('Xhome', 'rf') endfunc " Ignore the "failed to create input context" error. call test_ignore_error('E285')