Mercurial > vim
view src/proto/spell.pro @ 34379:37b4c89ba420 v9.1.0116
patch 9.1.0116: win_split_ins may not check available room
Commit: https://github.com/vim/vim/commit/0fd44a5ad81ade342cb54d8984965bdedd2272c8
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Feb 20 20:28:15 2024 +0100
patch 9.1.0116: win_split_ins may not check available room
Problem: win_split_ins has no check for E36 when moving an existing
window
Solution: check for room and fix the issues in f_win_splitmove()
(Sean Dewar)
win_split_ins has no check for E36 when moving an existing window,
allowing for layouts with many overlapping zero-sized windows to be
created (which may also cause drawing issues with tablines and such).
f_win_splitmove also has some bugs.
So check for room and fix the issues in f_win_splitmove. Handle failure
in the two relevant win_split_ins callers by restoring the original
layout, and factor the common logic into win_splitmove.
Don't check for room when opening an autocommand window, as it's a
temporary window that's rarely interacted with or drawn anyhow, and is
rather important for some autocommands.
Issues fixed in f_win_splitmove:
- Error if splitting is disallowed.
- Fix heap-use-after-frees if autocommands fired from switching to "targetwin"
close "wp" or "oldwin".
- Fix splitting the wrong window if autocommands fired from switching to
"targetwin" switch to a different window.
- Ensure -1 is returned for all errors.
Also handle allocation failure a bit earlier in make_snapshot (callers,
except win_splitmove, don't really care if a snapshot can't be made, so
just ignore the return value).
Note: Test_smoothscroll_in_zero_width_window failed after these changes with
E36, as it was using the previous behaviour to create a zero-width window.
I've fixed the test such that it fails with UBSAN as expected when v9.0.1367 is
reverted (and simplified it too).
related: #14042
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 20 Feb 2024 22:30:04 +0100 |
parents | 695b50472e85 |
children | ffa6ed03a9f2 |
line wrap: on
line source
/* spell.c */ int spell_check(win_T *wp, char_u *ptr, hlf_T *attrp, int *capcol, int docount); int match_checkcompoundpattern(char_u *ptr, int wlen, garray_T *gap); int can_compound(slang_T *slang, char_u *word, char_u *flags); int match_compoundrule(slang_T *slang, char_u *compflags); int valid_word_prefix(int totprefcnt, int arridx, int flags, char_u *word, slang_T *slang, int cond_req); int spell_valid_case(int wordflags, int treeflags); int spell_check_window(win_T *wp); int spell_move_to(win_T *wp, int dir, int allwords, int curline, hlf_T *attrp); void spell_cat_line(char_u *buf, char_u *line, int maxlen); char_u *spell_enc(void); slang_T *slang_alloc(char_u *lang); void slang_free(slang_T *lp); void slang_clear(slang_T *lp); void slang_clear_sug(slang_T *lp); void count_common_word(slang_T *lp, char_u *word, int len, int count); int byte_in_str(char_u *str, int n); int init_syl_tab(slang_T *slang); char *parse_spelllang(win_T *wp); int captype(char_u *word, char_u *end); void spell_delete_wordlist(void); void spell_free_all(void); void spell_reload(void); buf_T *open_spellbuf(void); void close_spellbuf(buf_T *buf); void clear_spell_chartab(spelltab_T *sp); void init_spell_chartab(void); int spell_iswordp(char_u *p, win_T *wp); int spell_iswordp_nmw(char_u *p, win_T *wp); int spell_casefold(win_T *wp, char_u *str, int len, char_u *buf, int buflen); int check_need_cap(win_T *wp, linenr_T lnum, colnr_T col); void ex_spellrepall(exarg_T *eap); void onecap_copy(char_u *word, char_u *wcopy, int upper); void allcap_copy(char_u *word, char_u *wcopy); int nofold_len(char_u *fword, int flen, char_u *word); void make_case_word(char_u *fword, char_u *cword, int flags); char_u *eval_soundfold(char_u *word); void spell_soundfold(slang_T *slang, char_u *inword, int folded, char_u *res); void ex_spellinfo(exarg_T *eap); void ex_spelldump(exarg_T *eap); void spell_dump_compl(char_u *pat, int ic, int *dir, int dumpflags_arg); char_u *spell_to_word_end(char_u *start, win_T *win); int spell_word_start(int startcol); void spell_expand_check_cap(colnr_T col); int expand_spelling(linenr_T lnum, char_u *pat, char_u ***matchp); int valid_spelllang(char_u *val); int valid_spellfile(char_u *val); char *did_set_spell_option(int is_spellfile); char *compile_cap_prog(synblock_T *synblock); /* vim: set ft=c : */