Mercurial > vim
view src/proto/evalwindow.pro @ 34379:37b4c89ba420 v9.1.0116
patch 9.1.0116: win_split_ins may not check available room
Commit: https://github.com/vim/vim/commit/0fd44a5ad81ade342cb54d8984965bdedd2272c8
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Feb 20 20:28:15 2024 +0100
patch 9.1.0116: win_split_ins may not check available room
Problem: win_split_ins has no check for E36 when moving an existing
window
Solution: check for room and fix the issues in f_win_splitmove()
(Sean Dewar)
win_split_ins has no check for E36 when moving an existing window,
allowing for layouts with many overlapping zero-sized windows to be
created (which may also cause drawing issues with tablines and such).
f_win_splitmove also has some bugs.
So check for room and fix the issues in f_win_splitmove. Handle failure
in the two relevant win_split_ins callers by restoring the original
layout, and factor the common logic into win_splitmove.
Don't check for room when opening an autocommand window, as it's a
temporary window that's rarely interacted with or drawn anyhow, and is
rather important for some autocommands.
Issues fixed in f_win_splitmove:
- Error if splitting is disallowed.
- Fix heap-use-after-frees if autocommands fired from switching to "targetwin"
close "wp" or "oldwin".
- Fix splitting the wrong window if autocommands fired from switching to
"targetwin" switch to a different window.
- Ensure -1 is returned for all errors.
Also handle allocation failure a bit earlier in make_snapshot (callers,
except win_splitmove, don't really care if a snapshot can't be made, so
just ignore the return value).
Note: Test_smoothscroll_in_zero_width_window failed after these changes with
E36, as it was using the previous behaviour to create a zero-width window.
I've fixed the test such that it fails with UBSAN as expected when v9.0.1367 is
reverted (and simplified it too).
related: #14042
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 20 Feb 2024 22:30:04 +0100 |
parents | b94cdb5ef20e |
children |
line wrap: on
line source
/* evalwindow.c */ win_T *win_id2wp(int id); win_T *win_id2wp_tp(int id, tabpage_T **tpp); void win_findbuf(typval_T *argvars, list_T *list); win_T *find_win_by_nr(typval_T *vp, tabpage_T *tp); win_T *find_win_by_nr_or_id(typval_T *vp); win_T *find_tabwin(typval_T *wvp, typval_T *tvp, tabpage_T **ptp); void f_gettabinfo(typval_T *argvars, typval_T *rettv); void f_getwininfo(typval_T *argvars, typval_T *rettv); void f_getwinpos(typval_T *argvars, typval_T *rettv); void f_getwinposx(typval_T *argvars, typval_T *rettv); void f_getwinposy(typval_T *argvars, typval_T *rettv); void f_tabpagenr(typval_T *argvars, typval_T *rettv); void f_tabpagewinnr(typval_T *argvars, typval_T *rettv); void f_win_execute(typval_T *argvars, typval_T *rettv); void f_win_findbuf(typval_T *argvars, typval_T *rettv); void f_win_getid(typval_T *argvars, typval_T *rettv); void f_win_gotoid(typval_T *argvars, typval_T *rettv); void f_win_id2tabwin(typval_T *argvars, typval_T *rettv); void f_win_id2win(typval_T *argvars, typval_T *rettv); void f_win_move_separator(typval_T *argvars, typval_T *rettv); void f_win_move_statusline(typval_T *argvars, typval_T *rettv); void f_win_screenpos(typval_T *argvars, typval_T *rettv); void f_win_splitmove(typval_T *argvars, typval_T *rettv); void f_win_gettype(typval_T *argvars, typval_T *rettv); void f_getcmdwintype(typval_T *argvars, typval_T *rettv); void f_winbufnr(typval_T *argvars, typval_T *rettv); void f_wincol(typval_T *argvars, typval_T *rettv); void f_winheight(typval_T *argvars, typval_T *rettv); void f_winlayout(typval_T *argvars, typval_T *rettv); void f_winline(typval_T *argvars, typval_T *rettv); void f_winnr(typval_T *argvars, typval_T *rettv); void f_winrestcmd(typval_T *argvars, typval_T *rettv); void f_winrestview(typval_T *argvars, typval_T *rettv); void f_winsaveview(typval_T *argvars, typval_T *rettv); void f_winwidth(typval_T *argvars, typval_T *rettv); int switch_win(switchwin_T *switchwin, win_T *win, tabpage_T *tp, int no_display); int switch_win_noblock(switchwin_T *switchwin, win_T *win, tabpage_T *tp, int no_display); void restore_win(switchwin_T *switchwin, int no_display); void restore_win_noblock(switchwin_T *switchwin, int no_display); /* vim: set ft=c : */