Mercurial > vim
view runtime/syntax/exports.vim @ 34379:37b4c89ba420 v9.1.0116
patch 9.1.0116: win_split_ins may not check available room
Commit: https://github.com/vim/vim/commit/0fd44a5ad81ade342cb54d8984965bdedd2272c8
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Feb 20 20:28:15 2024 +0100
patch 9.1.0116: win_split_ins may not check available room
Problem: win_split_ins has no check for E36 when moving an existing
window
Solution: check for room and fix the issues in f_win_splitmove()
(Sean Dewar)
win_split_ins has no check for E36 when moving an existing window,
allowing for layouts with many overlapping zero-sized windows to be
created (which may also cause drawing issues with tablines and such).
f_win_splitmove also has some bugs.
So check for room and fix the issues in f_win_splitmove. Handle failure
in the two relevant win_split_ins callers by restoring the original
layout, and factor the common logic into win_splitmove.
Don't check for room when opening an autocommand window, as it's a
temporary window that's rarely interacted with or drawn anyhow, and is
rather important for some autocommands.
Issues fixed in f_win_splitmove:
- Error if splitting is disallowed.
- Fix heap-use-after-frees if autocommands fired from switching to "targetwin"
close "wp" or "oldwin".
- Fix splitting the wrong window if autocommands fired from switching to
"targetwin" switch to a different window.
- Ensure -1 is returned for all errors.
Also handle allocation failure a bit earlier in make_snapshot (callers,
except win_splitmove, don't really care if a snapshot can't be made, so
just ignore the return value).
Note: Test_smoothscroll_in_zero_width_window failed after these changes with
E36, as it was using the previous behaviour to create a zero-width window.
I've fixed the test such that it fails with UBSAN as expected when v9.0.1367 is
reverted (and simplified it too).
related: #14042
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 20 Feb 2024 22:30:04 +0100 |
parents | 02bd0fe77c68 |
children |
line wrap: on
line source
" Vim syntax file " Language: exports " Maintainer: This runtime file is looking for a new maintainer. " Former Maintainer: Charles E. Campbell " Last Change: Aug 31, 2016 " Version: 8 " Notes: This file includes both SysV and BSD 'isms " Former URL: http://www.drchip.org/astronaut/vim/index.html#SYNTAX_EXPORTS " quit when a syntax file was already loaded if exists("b:current_syntax") finish endif " Options: -word syn keyword exportsKeyOptions contained alldirs nohide ro wsync syn keyword exportsKeyOptions contained kerb o rw syn match exportsOptError contained "[a-z]\+" " Settings: word= syn keyword exportsKeySettings contained access anon root rw syn match exportsSetError contained "[a-z]\+" " OptSet: -word= syn keyword exportsKeyOptSet contained mapall maproot mask network syn match exportsOptSetError contained "[a-z]\+" " options and settings syn match exportsSettings "[a-z]\+=" contains=exportsKeySettings,exportsSetError syn match exportsOptions "-[a-z]\+" contains=exportsKeyOptions,exportsOptError syn match exportsOptSet "-[a-z]\+=" contains=exportsKeyOptSet,exportsOptSetError " Separators syn match exportsSeparator "[,:]" " comments syn match exportsComment "^\s*#.*$" contains=@Spell " Define the default highlighting. if !exists("skip_exports_syntax_inits") hi def link exportsKeyOptSet exportsKeySettings hi def link exportsOptSet exportsSettings hi def link exportsComment Comment hi def link exportsKeyOptions Type hi def link exportsKeySettings Keyword hi def link exportsOptions Constant hi def link exportsSeparator Constant hi def link exportsSettings Constant hi def link exportsOptError Error hi def link exportsOptSetError Error hi def link exportsSetError Error endif let b:current_syntax = "exports" " vim: ts=10