Mercurial > vim
view src/nbdebug.h @ 33862:242b964d6269 v9.0.2140
patch 9.0.2140: [security]: use-after-free in win-enter
Commit: https://github.com/vim/vim/commit/eec0c2b3a4cfab93dd8d4adaa60638d47a2bbc8a
Author: Christian Brabandt <cb@256bit.org>
Date: Tue Nov 28 22:03:48 2023 +0100
patch 9.0.2140: [security]: use-after-free in win-enter
Problem: [security]: use-after-free in win-enter
Solution: validate window pointer before calling win_enter()
win_goto() may stop visual mode, if it is active. However, this may in
turn trigger the ModeChanged autocommand, which could potentially free
the wp pointer which was valid before now became stale and points to now
freed memory.
So before calling win_enter(), let's verify one more time, that the
wp pointer still points to a valid window structure.
Reported by @henices, thanks!
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Sun, 10 Dec 2023 15:16:01 +0100 |
parents | 50555279168b |
children |
line wrap: on
line source
/* vi:set ts=8 sw=8 noet: * * VIM - Vi IMproved by Bram Moolenaar * Visual Workshop integration by Gordon Prieur * * Do ":help uganda" in Vim to read copying and usage conditions. * Do ":help credits" in Vim to see a list of people who contributed. */ #ifndef NBDEBUG_H #define NBDEBUG_H #ifdef NBDEBUG # ifndef ASSERT # define ASSERT(c) \ if (!(c)) \ { \ fprintf(stderr, "Assertion failed: line %d, file %s\n", \ __LINE__, __FILE__); \ fflush(stderr); \ abort(); \ } # endif # define nbdebug(a) nbdbg a # define NB_TRACE 0x00000001 # define NB_TRACE_VERBOSE 0x00000002 # define NB_TRACE_COLONCMD 0x00000004 # define NB_PRINT 0x00000008 # define NB_DEBUG_ALL 0xffffffff # define NBDLEVEL(flags) (nb_debug != NULL && (nb_dlevel & (flags))) # define NBDEBUG_TRACE 1 typedef enum { WT_ENV = 1, // look for env var if set WT_WAIT, // look for ~/.gvimwait if set WT_STOP // look for ~/.gvimstop if set } WtWait; void nbdbg(char *, ...) ATTRIBUTE_FORMAT_PRINTF(1, 2); void nbdebug_wait(u_int wait_flags, char *wait_var, u_int wait_secs); void nbdebug_log_init(char *log_var, char *level_var); extern FILE *nb_debug; extern u_int nb_dlevel; // nb_debug verbosity level #else // not NBDEBUG # ifndef ASSERT # define ASSERT(c) # endif /* * The following 3 stubs are needed because a macro cannot be used because of * the variable number of arguments. */ void nbdbg( char *fmt, ...) { } #endif // NBDEBUG #endif // NBDEBUG_H