Mercurial > vim
view src/testdir/test_suspend.vim @ 34074:1629cc65d78d v9.1.0006
patch 9.1.0006: is*() and to*() function may be unsafe
Commit: https://github.com/vim/vim/commit/184f71cc6868a240dc872ed2852542bbc1d43e28
Author: Keith Thompson <Keith.S.Thompson@gmail.com>
Date: Thu Jan 4 21:19:04 2024 +0100
patch 9.1.0006: is*() and to*() function may be unsafe
Problem: is*() and to*() function may be unsafe
Solution: Add SAFE_* macros and start using those instead
(Keith Thompson)
Use SAFE_() macros for is*() and to*() functions
The standard is*() and to*() functions declared in <ctype.h> have
undefined behavior for negative arguments other than EOF. If plain char
is signed, passing an unchecked value from argv for from user input
to one of these functions has undefined behavior.
Solution: Add SAFE_*() macros that cast the argument to unsigned char.
Most implementations behave sanely for negative arguments, and most
character values in practice are non-negative, but it's still best
to avoid undefined behavior.
The change from #13347 has been omitted, as this has already been
separately fixed in commit ac709e2fc0db6d31abb7da96f743c40956b60c3a
(v9.0.2054)
fixes: #13332
closes: #13347
Signed-off-by: Keith Thompson <Keith.S.Thompson@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Thu, 04 Jan 2024 21:30:04 +0100 |
parents | 543cb94c6c09 |
children |
line wrap: on
line source
" Test :suspend source check.vim source term_util.vim source shared.vim func CheckSuspended(buf, fileExists) call WaitForAssert({-> assert_match('[$#] $', term_getline(a:buf, '.'))}) if a:fileExists call assert_equal(['foo'], readfile('Xfoo')) else " Without 'autowrite', buffer should not be written. call assert_equal(0, filereadable('Xfoo')) endif call term_sendkeys(a:buf, "fg\<CR>\<C-L>") call WaitForAssert({-> assert_equal(' 1 foo', term_getline(a:buf, '.'))}) endfunc func Test_suspend() CheckFeature terminal CheckExecutable /bin/sh " Somehow the modifyOtherKeys response may get to the terminal when using " Mac OS. Make t_RK and 'keyprotocol' empty to avoid that. set t_RK= keyprotocol= call WaitForResponses() let buf = term_start('/bin/sh') " Wait for shell prompt. call WaitForAssert({-> assert_match('[$#] $', term_getline(buf, '.'))}) call term_sendkeys(buf, v:progpath \ . " --clean -X" \ . " -c 'set nu keyprotocol='" \ . " -c 'call setline(1, \"foo\")'" \ . " Xfoo\<CR>") " Cursor in terminal buffer should be on first line in spawned vim. call WaitForAssert({-> assert_equal(' 1 foo', term_getline(buf, '.'))}) for suspend_cmd in [":suspend\<CR>", \ ":stop\<CR>", \ ":suspend!\<CR>", \ ":stop!\<CR>", \ "\<C-Z>"] " Suspend and wait for shell prompt. call term_sendkeys(buf, suspend_cmd) call CheckSuspended(buf, 0) endfor " Test that :suspend! with 'autowrite' writes content of buffers if modified. call term_sendkeys(buf, ":set autowrite\<CR>") call assert_equal(0, filereadable('Xfoo')) call term_sendkeys(buf, ":suspend\<CR>") " Wait for shell prompt. call CheckSuspended(buf, 1) " Quit gracefully to dump coverage information. call term_sendkeys(buf, ":qall!\<CR>") call TermWait(buf) " Wait until Vim actually exited and shell shows a prompt call WaitForAssert({-> assert_match('[$#] $', term_getline(buf, '.'))}) call StopShellInTerminal(buf) exe buf . 'bwipe!' call delete('Xfoo') endfunc func Test_suspend_autocmd() CheckFeature terminal CheckExecutable /bin/sh " Somehow the modifyOtherKeys response may get to the terminal when using " Mac OS. Make t_RK and 'keyprotocol' empty to avoid that. set t_RK= keyprotocol= call WaitForResponses() let buf = term_start('/bin/sh', #{term_rows: 6}) " Wait for shell prompt. call WaitForAssert({-> assert_match('[$#] $', term_getline(buf, '.'))}) call term_sendkeys(buf, v:progpath \ . " --clean -X" \ . " -c 'set nu keyprotocol='" \ . " -c 'let g:count = 0'" \ . " -c 'au VimSuspend * let g:count += 1'" \ . " -c 'au VimResume * let g:count += 1'" \ . " -c 'call setline(1, \"foo\")'" \ . " Xfoo\<CR>") " Cursor in terminal buffer should be on first line in spawned vim. call WaitForAssert({-> assert_equal(' 1 foo', term_getline(buf, '.'))}) for suspend_cmd in [":suspend\<CR>", \ ":stop\<CR>", \ ":suspend!\<CR>", \ ":stop!\<CR>", \ "\<C-Z>"] " Suspend and wait for shell prompt. Then "fg" will restore Vim. call term_sendkeys(buf, suspend_cmd) call CheckSuspended(buf, 0) endfor call term_sendkeys(buf, ":echo g:count\<CR>") call TermWait(buf) call WaitForAssert({-> assert_match('^10', term_getline(buf, 6))}) " Quit gracefully to dump coverage information. call term_sendkeys(buf, ":qall!\<CR>") call TermWait(buf) " Wait until Vim actually exited and shell shows a prompt call WaitForAssert({-> assert_match('[$#] $', term_getline(buf, '.'))}) call StopShellInTerminal(buf) exe buf . 'bwipe!' call delete('Xfoo') endfunc " vim: shiftwidth=2 sts=2 expandtab