Mercurial > vim
view src/testdir/test_set.vim @ 34074:1629cc65d78d v9.1.0006
patch 9.1.0006: is*() and to*() function may be unsafe
Commit: https://github.com/vim/vim/commit/184f71cc6868a240dc872ed2852542bbc1d43e28
Author: Keith Thompson <Keith.S.Thompson@gmail.com>
Date: Thu Jan 4 21:19:04 2024 +0100
patch 9.1.0006: is*() and to*() function may be unsafe
Problem: is*() and to*() function may be unsafe
Solution: Add SAFE_* macros and start using those instead
(Keith Thompson)
Use SAFE_() macros for is*() and to*() functions
The standard is*() and to*() functions declared in <ctype.h> have
undefined behavior for negative arguments other than EOF. If plain char
is signed, passing an unchecked value from argv for from user input
to one of these functions has undefined behavior.
Solution: Add SAFE_*() macros that cast the argument to unsigned char.
Most implementations behave sanely for negative arguments, and most
character values in practice are non-negative, but it's still best
to avoid undefined behavior.
The change from #13347 has been omitted, as this has already been
separately fixed in commit ac709e2fc0db6d31abb7da96f743c40956b60c3a
(v9.0.2054)
fixes: #13332
closes: #13347
Signed-off-by: Keith Thompson <Keith.S.Thompson@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Thu, 04 Jan 2024 21:30:04 +0100 |
parents | 9a7fb0665f9f |
children |
line wrap: on
line source
" Tests for the :set command source check.vim function Test_set_backslash() let isk_save = &isk set isk=a,b,c set isk+=d call assert_equal('a,b,c,d', &isk) set isk+=\\,e call assert_equal('a,b,c,d,\,e', &isk) set isk-=e call assert_equal('a,b,c,d,\', &isk) set isk-=\\ call assert_equal('a,b,c,d', &isk) let &isk = isk_save endfunction function Test_set_add() let wig_save = &wig set wildignore=*.png, set wildignore+=*.jpg call assert_equal('*.png,*.jpg', &wig) let &wig = wig_save endfunction " :set, :setlocal, :setglobal without arguments show values of options. func Test_set_no_arg() set textwidth=79 let a = execute('set') call assert_match("^\n--- Options ---\n.*textwidth=79\\>", a) set textwidth& setlocal textwidth=78 let a = execute('setlocal') call assert_match("^\n--- Local option values ---\n.*textwidth=78\\>", a) setlocal textwidth& setglobal textwidth=77 let a = execute('setglobal') call assert_match("^\n--- Global option values ---\n.*textwidth=77\\>", a) setglobal textwidth& endfunc func Test_set_termcap() CheckNotGui let lines = split(execute('set termcap'), "\n") call assert_match('--- Terminal codes ---', lines[0]) " four columns call assert_match('t_..=.*t_..=.*t_..=.*t_..=', lines[1]) for keys_idx in range(len(lines)) if lines[keys_idx] =~ '--- Terminal keys ---' break endif endfor call assert_true(keys_idx < len(lines)) " three columns call assert_match('<[^>]*> .*<[^>]*> .*<[^>]*> ', lines[keys_idx + 1]) let more_lines = split(execute('set! termcap'), "\n") for i in range(len(more_lines)) if more_lines[i] =~ '--- Terminal keys ---' break endif endfor call assert_true(i < len(more_lines)) call assert_true(i > keys_idx) call assert_true(len(more_lines) - i > len(lines) - keys_idx) endfunc " vim: shiftwidth=2 sts=2 expandtab