Mercurial > vim
view src/testdir/test_move.vim @ 34074:1629cc65d78d v9.1.0006
patch 9.1.0006: is*() and to*() function may be unsafe
Commit: https://github.com/vim/vim/commit/184f71cc6868a240dc872ed2852542bbc1d43e28
Author: Keith Thompson <Keith.S.Thompson@gmail.com>
Date: Thu Jan 4 21:19:04 2024 +0100
patch 9.1.0006: is*() and to*() function may be unsafe
Problem: is*() and to*() function may be unsafe
Solution: Add SAFE_* macros and start using those instead
(Keith Thompson)
Use SAFE_() macros for is*() and to*() functions
The standard is*() and to*() functions declared in <ctype.h> have
undefined behavior for negative arguments other than EOF. If plain char
is signed, passing an unchecked value from argv for from user input
to one of these functions has undefined behavior.
Solution: Add SAFE_*() macros that cast the argument to unsigned char.
Most implementations behave sanely for negative arguments, and most
character values in practice are non-negative, but it's still best
to avoid undefined behavior.
The change from #13347 has been omitted, as this has already been
separately fixed in commit ac709e2fc0db6d31abb7da96f743c40956b60c3a
(v9.0.2054)
fixes: #13332
closes: #13347
Signed-off-by: Keith Thompson <Keith.S.Thompson@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Thu, 04 Jan 2024 21:30:04 +0100 |
| parents | 984969b81d63 |
| children |
line wrap: on
line source
" Test the ":move" command. source check.vim source screendump.vim func Test_move() enew! call append(0, ['line 1', 'line 2', 'line 3']) g /^$/ delete _ set nomodified move . call assert_equal(['line 1', 'line 2', 'line 3'], getline(1, 3)) call assert_false(&modified) 1,2move 0 call assert_equal(['line 1', 'line 2', 'line 3'], getline(1, 3)) call assert_false(&modified) 1,3move 3 call assert_equal(['line 1', 'line 2', 'line 3'], getline(1, 3)) call assert_false(&modified) 1move 2 call assert_equal(['line 2', 'line 1', 'line 3'], getline(1, 3)) call assert_true(&modified) set nomodified 3move 0 call assert_equal(['line 3', 'line 2', 'line 1'], getline(1, 3)) call assert_true(&modified) set nomodified 2,3move 0 call assert_equal(['line 2', 'line 1', 'line 3'], getline(1, 3)) call assert_true(&modified) set nomodified call assert_fails('1,2move 1', 'E134:') call assert_fails('2,3move 2', 'E134:') call assert_fails("move -100", 'E16:') call assert_fails("move +100", 'E16:') call assert_fails('move', 'E16:') call assert_fails("move 'r", 'E20:') %bwipeout! endfunc func Test_move_undo() CheckRunVimInTerminal let lines =<< trim END call setline(1, ['First', 'Second', 'Third', 'Fourth']) END call writefile(lines, 'Xtest_move_undo.vim', 'D') let buf = RunVimInTerminal('-S Xtest_move_undo.vim', #{rows: 10, cols: 60, statusoff: 2}) call term_sendkeys(buf, "gg:move +1\<CR>") call VerifyScreenDump(buf, 'Test_move_undo_1', {}) " here the display would show the last few lines scrolled down call term_sendkeys(buf, "u") call term_sendkeys(buf, ":\<Esc>") call VerifyScreenDump(buf, 'Test_move_undo_2', {}) call StopVimInTerminal(buf) endfunc " vim: shiftwidth=2 sts=2 expandtab