Mercurial > vim
view src/testdir/test_ins_complete_no_halt.vim @ 34074:1629cc65d78d v9.1.0006
patch 9.1.0006: is*() and to*() function may be unsafe
Commit: https://github.com/vim/vim/commit/184f71cc6868a240dc872ed2852542bbc1d43e28
Author: Keith Thompson <Keith.S.Thompson@gmail.com>
Date: Thu Jan 4 21:19:04 2024 +0100
patch 9.1.0006: is*() and to*() function may be unsafe
Problem: is*() and to*() function may be unsafe
Solution: Add SAFE_* macros and start using those instead
(Keith Thompson)
Use SAFE_() macros for is*() and to*() functions
The standard is*() and to*() functions declared in <ctype.h> have
undefined behavior for negative arguments other than EOF. If plain char
is signed, passing an unchecked value from argv for from user input
to one of these functions has undefined behavior.
Solution: Add SAFE_*() macros that cast the argument to unsigned char.
Most implementations behave sanely for negative arguments, and most
character values in practice are non-negative, but it's still best
to avoid undefined behavior.
The change from #13347 has been omitted, as this has already been
separately fixed in commit ac709e2fc0db6d31abb7da96f743c40956b60c3a
(v9.0.2054)
fixes: #13332
closes: #13347
Signed-off-by: Keith Thompson <Keith.S.Thompson@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Thu, 04 Jan 2024 21:30:04 +0100 |
parents | b9e8c9ed792b |
children |
line wrap: on
line source
" Test insert mode completion does not get stuck when looping around. " In a separate file to avoid the settings to leak to other test cases. set complete+=kspell set completeopt+=menu set completeopt+=menuone set completeopt+=noselect set completeopt+=noinsert let g:autocompletion = v:true func Test_ins_complete_no_halt() function! OpenCompletion() if pumvisible() && (g:autocompletion == v:true) call feedkeys("\<C-e>\<C-n>", "i") return endif if ((v:char >= 'a' && v:char <= 'z') || (v:char >= 'A' && v:char <= 'Z')) && (g:autocompletion == v:true) call feedkeys("\<C-n>", "i") redraw endif endfunction autocmd InsertCharPre * noautocmd call OpenCompletion() setlocal spell! spelllang=en_us call feedkeys("iauto-complete-halt-test test test test test test test test test test test test test test test test test test test\<C-c>", "tx!") call assert_equal(["auto-complete-halt-test test test test test test test test test test test test test test test test test test test"], getline(1, "$")) endfunc func Test_auto_complete_backwards_no_halt() function! OpenCompletion() if pumvisible() && (g:autocompletion == v:true) call feedkeys("\<C-e>\<C-p>", "i") return endif if ((v:char >= 'a' && v:char <= 'z') || (v:char >= 'A' && v:char <= 'Z')) && (g:autocompletion == v:true) call feedkeys("\<C-p>", "i") redraw endif endfunction autocmd InsertCharPre * noautocmd call OpenCompletion() setlocal spell! spelllang=en_us call feedkeys("iauto-complete-halt-test test test test test test test test test test test test test test test test test test test\<C-c>", "tx!") call assert_equal(["auto-complete-halt-test test test test test test test test test test test test test test test test test test test"], getline(1, "$")) endfunc " vim: shiftwidth=2 sts=2 expandtab