Mercurial > vim
view src/testdir/test_function_lists.vim @ 34074:1629cc65d78d v9.1.0006
patch 9.1.0006: is*() and to*() function may be unsafe
Commit: https://github.com/vim/vim/commit/184f71cc6868a240dc872ed2852542bbc1d43e28
Author: Keith Thompson <Keith.S.Thompson@gmail.com>
Date: Thu Jan 4 21:19:04 2024 +0100
patch 9.1.0006: is*() and to*() function may be unsafe
Problem: is*() and to*() function may be unsafe
Solution: Add SAFE_* macros and start using those instead
(Keith Thompson)
Use SAFE_() macros for is*() and to*() functions
The standard is*() and to*() functions declared in <ctype.h> have
undefined behavior for negative arguments other than EOF. If plain char
is signed, passing an unchecked value from argv for from user input
to one of these functions has undefined behavior.
Solution: Add SAFE_*() macros that cast the argument to unsigned char.
Most implementations behave sanely for negative arguments, and most
character values in practice are non-negative, but it's still best
to avoid undefined behavior.
The change from #13347 has been omitted, as this has already been
separately fixed in commit ac709e2fc0db6d31abb7da96f743c40956b60c3a
(v9.0.2054)
fixes: #13332
closes: #13347
Signed-off-by: Keith Thompson <Keith.S.Thompson@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Thu, 04 Jan 2024 21:30:04 +0100 |
| parents | a52697bcffa6 |
| children |
line wrap: on
line source
" Test to verify that the three function lists: " " - global_functions[] in src/evalfunc.c " - *functions* in runtime/doc/builtin.txt " - *function-list* in runtime/doc/usr_41.txt " " contain the same functions and that the global_functions and " ":help functions" lists are in ASCII order. func Test_function_lists() " Delete any files left over from an earlier run of this test. call delete("Xglobal_functions.diff") call delete("Xfunctions.diff") call delete("Xfunction-list.diff") " Create a file of the functions in evalfunc.c:global_functions[]. enew! read ../evalfunc.c 1,/^static funcentry_T global_functions\[\] =$/d call search('^};$') .,$d v/^ {/d %s/^ {"// %s/".*// w! Xglobal_functions " Verify that those functions are in ASCII order. sort u w! Xsorted_global_functions let l:unequal = assert_equalfile("Xsorted_global_functions", "Xglobal_functions", \ "global_functions[] not sorted") if l:unequal && executable("diff") call system("diff -u Xsorted_global_functions Xglobal_functions > Xglobal_functions.diff") endif " Create a file of the functions in evalfunc.c:global_functions[] that are " not obsolete, sorted in ASCII order. enew! read ../evalfunc.c 1,/^static funcentry_T global_functions\[\] =$/d call search('^};$') .,$d v/^ {/d g/\/\/ obsolete$/d %s/^ {"// %s/".*// sort u w! ++ff=unix Xsorted_current_global_functions " Verify that the ":help functions" list is complete and in ASCII order. enew! if filereadable('../../doc/builtin.txt') " unpacked MS-Windows zip archive read ../../doc/builtin.txt else read ../../runtime/doc/builtin.txt endif call search('^USAGE') 1,.d call search('^==========') .,$d v/^\S/d %s/(.*// let l:lines = getline(1, '$') call uniq(l:lines) call writefile(l:lines, "Xfunctions") let l:unequal = assert_equalfile("Xsorted_current_global_functions", "Xfunctions", \ "\":help functions\" not sorted or incomplete") if l:unequal && executable("diff") call system("diff -u Xsorted_current_global_functions Xfunctions > Xfunctions.diff") endif " Verify that the ":help function-list" list is complete. enew! if filereadable('../../doc/usr_41.txt') " unpacked MS-Windows zip archive read ../../doc/usr_41.txt else read ../../runtime/doc/usr_41.txt endif call search('\*function-list\*$') 1,.d call search('^==*$') .,$d v/^\t\S/d %s/(.*// %left sort u w! ++ff=unix Xfunction-list let l:unequal = assert_equalfile("Xsorted_current_global_functions", "Xfunction-list", \ "\":help function-list\" incomplete") if l:unequal && executable("diff") call system("diff -u Xsorted_current_global_functions Xfunction-list > Xfunction-list.diff") endif " Clean up. call delete("Xglobal_functions") call delete("Xsorted_global_functions") call delete("Xsorted_current_global_functions") call delete("Xfunctions") call delete("Xfunction-list") enew! endfunc " vim: shiftwidth=2 sts=2 expandtab