Mercurial > vim
view src/testdir/test_backup.vim @ 34074:1629cc65d78d v9.1.0006
patch 9.1.0006: is*() and to*() function may be unsafe
Commit: https://github.com/vim/vim/commit/184f71cc6868a240dc872ed2852542bbc1d43e28
Author: Keith Thompson <Keith.S.Thompson@gmail.com>
Date: Thu Jan 4 21:19:04 2024 +0100
patch 9.1.0006: is*() and to*() function may be unsafe
Problem: is*() and to*() function may be unsafe
Solution: Add SAFE_* macros and start using those instead
(Keith Thompson)
Use SAFE_() macros for is*() and to*() functions
The standard is*() and to*() functions declared in <ctype.h> have
undefined behavior for negative arguments other than EOF. If plain char
is signed, passing an unchecked value from argv for from user input
to one of these functions has undefined behavior.
Solution: Add SAFE_*() macros that cast the argument to unsigned char.
Most implementations behave sanely for negative arguments, and most
character values in practice are non-negative, but it's still best
to avoid undefined behavior.
The change from #13347 has been omitted, as this has already been
separately fixed in commit ac709e2fc0db6d31abb7da96f743c40956b60c3a
(v9.0.2054)
fixes: #13332
closes: #13347
Signed-off-by: Keith Thompson <Keith.S.Thompson@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Thu, 04 Jan 2024 21:30:04 +0100 |
| parents | ba5ca7c7d44c |
| children |
line wrap: on
line source
" Tests for the backup function source check.vim func Test_backup() set backup backupdir=. backupskip= new call setline(1, ['line1', 'line2']) :f Xbackup.txt :w! Xbackup.txt " backup file is only created after " writing a second time (before overwriting) :w! Xbackup.txt let l = readfile('Xbackup.txt~') call assert_equal(['line1', 'line2'], l) bw! set backup&vim backupdir&vim backupskip&vim call delete('Xbackup.txt') call delete('Xbackup.txt~') endfunc func Test_backup_backupskip() set backup backupdir=. backupskip=*.txt new call setline(1, ['line1', 'line2']) :f Xbackup.txt :w! Xbackup.txt " backup file is only created after " writing a second time (before overwriting) :w! Xbackup.txt call assert_false(filereadable('Xbackup.txt~')) bw! set backup&vim backupdir&vim backupskip&vim call delete('Xbackup.txt') call delete('Xbackup.txt~') endfunc func Test_backup2() set backup backupdir=.// backupskip= new call setline(1, ['line1', 'line2', 'line3']) :f Xbackup.txt :w! Xbackup.txt " backup file is only created after " writing a second time (before overwriting) :w! Xbackup.txt sp *Xbackup.txt~ call assert_equal(['line1', 'line2', 'line3'], getline(1,'$')) let f = expand('%') call assert_match('%testdir%Xbackup.txt\~', f) bw! bw! call delete('Xbackup.txt') call delete(f) set backup&vim backupdir&vim backupskip&vim endfunc func Test_backup2_backupcopy() set backup backupdir=.// backupcopy=yes backupskip= new call setline(1, ['line1', 'line2', 'line3']) :f Xbackup.txt :w! Xbackup.txt " backup file is only created after " writing a second time (before overwriting) :w! Xbackup.txt sp *Xbackup.txt~ call assert_equal(['line1', 'line2', 'line3'], getline(1,'$')) let f = expand('%') call assert_match('%testdir%Xbackup.txt\~', f) bw! bw! call delete('Xbackup.txt') call delete(f) set backup&vim backupdir&vim backupcopy&vim backupskip&vim endfunc " Test for using a non-existing directory as a backup directory func Test_non_existing_backupdir() set backupdir=./non_existing_dir backupskip= call writefile(['line1'], 'Xbackupdir', 'D') new Xbackupdir call assert_fails('write', 'E510:') set backupdir&vim backupskip&vim endfunc " vim: shiftwidth=2 sts=2 expandtab