Mercurial > vim
view src/vimtutor @ 34485:157cf882799f v9.1.0150
patch 9.1.0150: Several minor 'winfixbuf' issues
Commit: https://github.com/vim/vim/commit/4bb505e28cac0389561fff78d8bbe0319c2bcf2f
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Mar 5 20:39:07 2024 +0100
patch 9.1.0150: Several minor 'winfixbuf' issues
Problem: several minor 'winfixbuf' issues exist, mostly relating to the
quickfix list
Solution: address them and adjust tests. Retab and reflow a few things too.
(Sean Dewar)
Things touched include:
- Replace the semsgs with gettext'd emsgs.
- Handle window switching in ex_listdo properly, so curbuf and curwin
are kept in-sync and trigger autocommands; handle those properly.
- Don't change the list entry index in qf_jump_edit_buffer if we fail
due to 'wfb' (achieved by returning FAIL; QF_ABORT should only be used
if the list was changed).
- Make qf_jump_edit_buffer actually switch to prevwin when using `:cXX`
commands **outside** of the list window if 'wfb' is set in curwin.
Handle autocommands properly in case they mess with the list.
NOTE: previously, it seemed to split if 'wfb' was set, but do nothing
and fail if prevwin is *valid*. This behaviour seemed strange, and maybe
unintentional? Now it aligns more with what's described for the `:cXX`
commands in the original PR description when used outside a list window,
I think.
- In both functions, only consider prevwin if 'wfb' isn't set for it;
fallback to splitting otherwise.
- Use win_split to split. Not sure if there was a specific reason for
using ex_splitview. win_split is simpler and respects modifiers like
:vertical that may have been used. Plus, its return value can be checked
for setting opened_window in qf code (technically win_split_ins autocmds
could immediately close it or change windows, in which the qf code might
close some other window on failure; it's already the case elsewhere,
though).
closes: #14142
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 05 Mar 2024 20:45:04 +0100 |
parents | d4faa2c5211b |
children |
line wrap: on
line source
#!/bin/sh # Start Vim on a copy of the tutor file. # Usage: vimtutor [-g] [xx] # Where optional argument -g starts vimtutor in gvim (GUI) instead of vim. # and xx is a language code like "es" or "nl". # When an argument is given, it tries loading that tutor. # When this fails or no argument was given, it tries using 'v:lang' # When that also fails, it uses the English version. # Vim could be called "vim" or "vi". Also check for "vimN", for people who # have Vim installed with its version number. # We anticipate up to a future Vim 8.1 version :-). seq="vim vim81 vim80 vim8 vim74 vim73 vim72 vim71 vim70 vim7 vim6 vi" if test "$1" = "-g"; then # Try to use the GUI version of Vim if possible, it will fall back # on Vim if Gvim is not installed. seq="gvim gvim81 gvim80 gvim8 gvim74 gvim73 gvim72 gvim71 gvim70 gvim7 gvim6 $seq" shift fi xx=$1 export xx # We need a temp file for the copy. First try using a standard command. tmp="${TMPDIR-/tmp}" TUTORCOPY=`mktemp $tmp/tutorXXXXXX || tempfile -p tutor || echo none` # If the standard commands failed then create a directory to put the copy in. # That is a secure way to make a temp file. if test "$TUTORCOPY" = none; then tmpdir=$tmp/vimtutor$$ OLD_UMASK=`umask` umask 077 getout=no mkdir $tmpdir || getout=yes umask $OLD_UMASK if test $getout = yes; then echo "Could not create directory for tutor copy, exiting." exit 1 fi TUTORCOPY=$tmpdir/tutorcopy touch $TUTORCOPY TODELETE=$tmpdir else TODELETE=$TUTORCOPY fi export TUTORCOPY # remove the copy of the tutor on exit trap "rm -rf $TODELETE" 0 1 2 3 9 11 13 15 for i in $seq; do testvim=$(which $i 2>/dev/null) if test -f "$testvim"; then VIM=$i break fi done # When no Vim version was found fall back to "vim", you'll get an error message # below. if test -z "$VIM"; then VIM=vim fi # Use Vim to copy the tutor, it knows the value of $VIMRUNTIME # The script tutor.vim tells Vim which file to copy $VIM -f -u NONE -c 'so $VIMRUNTIME/tutor/tutor.vim' # Start vim without any .vimrc, set 'nocompatible' and 'showcmd' $VIM -f -u NONE -c "set nocp showcmd" "$TUTORCOPY"