Mercurial > vim
view src/gui_x11_pm.h @ 34485:157cf882799f v9.1.0150
patch 9.1.0150: Several minor 'winfixbuf' issues
Commit: https://github.com/vim/vim/commit/4bb505e28cac0389561fff78d8bbe0319c2bcf2f
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Mar 5 20:39:07 2024 +0100
patch 9.1.0150: Several minor 'winfixbuf' issues
Problem: several minor 'winfixbuf' issues exist, mostly relating to the
quickfix list
Solution: address them and adjust tests. Retab and reflow a few things too.
(Sean Dewar)
Things touched include:
- Replace the semsgs with gettext'd emsgs.
- Handle window switching in ex_listdo properly, so curbuf and curwin
are kept in-sync and trigger autocommands; handle those properly.
- Don't change the list entry index in qf_jump_edit_buffer if we fail
due to 'wfb' (achieved by returning FAIL; QF_ABORT should only be used
if the list was changed).
- Make qf_jump_edit_buffer actually switch to prevwin when using `:cXX`
commands **outside** of the list window if 'wfb' is set in curwin.
Handle autocommands properly in case they mess with the list.
NOTE: previously, it seemed to split if 'wfb' was set, but do nothing
and fail if prevwin is *valid*. This behaviour seemed strange, and maybe
unintentional? Now it aligns more with what's described for the `:cXX`
commands in the original PR description when used outside a list window,
I think.
- In both functions, only consider prevwin if 'wfb' isn't set for it;
fallback to splitting otherwise.
- Use win_split to split. Not sure if there was a specific reason for
using ex_splitview. win_split is simpler and respects modifiers like
:vertical that may have been used. Plus, its return value can be checked
for setting opened_window in qf code (technically win_split_ins autocmds
could immediately close it or change windows, in which the qf code might
close some other window on failure; it's already the case elsewhere,
though).
closes: #14142
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Tue, 05 Mar 2024 20:45:04 +0100 |
| parents | 6e3dc2d630c2 |
| children |
line wrap: on
line source
/* vi:set ts=8 sts=4 sw=4 noet: * * VIM - Vi IMproved by Bram Moolenaar * GUI/Motif support by Robert Webb * * Do ":help uganda" in Vim to read copying and usage conditions. * Do ":help credits" in Vim to see a list of people who contributed. * See README.txt for an overview of the Vim source code. */ /* * Icons used by the toolbar code. */ #include "../pixmaps/tb_new.xpm" #include "../pixmaps/tb_open.xpm" #include "../pixmaps/tb_close.xpm" #include "../pixmaps/tb_save.xpm" #include "../pixmaps/tb_print.xpm" #include "../pixmaps/tb_cut.xpm" #include "../pixmaps/tb_copy.xpm" #include "../pixmaps/tb_paste.xpm" #include "../pixmaps/tb_find.xpm" #include "../pixmaps/tb_find_next.xpm" #include "../pixmaps/tb_find_prev.xpm" #include "../pixmaps/tb_find_help.xpm" #include "../pixmaps/tb_exit.xpm" #include "../pixmaps/tb_undo.xpm" #include "../pixmaps/tb_redo.xpm" #include "../pixmaps/tb_help.xpm" #include "../pixmaps/tb_macro.xpm" #include "../pixmaps/tb_make.xpm" #include "../pixmaps/tb_save_all.xpm" #include "../pixmaps/tb_jump.xpm" #include "../pixmaps/tb_ctags.xpm" #include "../pixmaps/tb_load_session.xpm" #include "../pixmaps/tb_save_session.xpm" #include "../pixmaps/tb_new_session.xpm" #include "../pixmaps/tb_blank.xpm" #include "../pixmaps/tb_maximize.xpm" #include "../pixmaps/tb_split.xpm" #include "../pixmaps/tb_minimize.xpm" #include "../pixmaps/tb_shell.xpm" #include "../pixmaps/tb_replace.xpm" #include "../pixmaps/tb_vsplit.xpm" #include "../pixmaps/tb_maxwidth.xpm" #include "../pixmaps/tb_minwidth.xpm" /* * Those are the pixmaps used for the default buttons. */ static char **(built_in_pixmaps[]) = { tb_new_xpm, tb_open_xpm, tb_save_xpm, tb_undo_xpm, tb_redo_xpm, tb_cut_xpm, tb_copy_xpm, tb_paste_xpm, tb_print_xpm, tb_help_xpm, tb_find_xpm, tb_save_all_xpm, tb_save_session_xpm, tb_new_session_xpm, tb_load_session_xpm, tb_macro_xpm, tb_replace_xpm, tb_close_xpm, tb_maximize_xpm, tb_minimize_xpm, tb_split_xpm, tb_shell_xpm, tb_find_prev_xpm, tb_find_next_xpm, tb_find_help_xpm, tb_make_xpm, tb_jump_xpm, tb_ctags_xpm, tb_vsplit_xpm, tb_maxwidth_xpm, tb_minwidth_xpm, tb_exit_xpm }; // Indices for named colors #define BACKGROUND 0 #define FOREGROUND 1 #define BOTTOM_SHADOW 2 #define TOP_SHADOW 3 #define HIGHLIGHT 4