Mercurial > vim
view runtime/bugreport.vim @ 34485:157cf882799f v9.1.0150
patch 9.1.0150: Several minor 'winfixbuf' issues
Commit: https://github.com/vim/vim/commit/4bb505e28cac0389561fff78d8bbe0319c2bcf2f
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Mar 5 20:39:07 2024 +0100
patch 9.1.0150: Several minor 'winfixbuf' issues
Problem: several minor 'winfixbuf' issues exist, mostly relating to the
quickfix list
Solution: address them and adjust tests. Retab and reflow a few things too.
(Sean Dewar)
Things touched include:
- Replace the semsgs with gettext'd emsgs.
- Handle window switching in ex_listdo properly, so curbuf and curwin
are kept in-sync and trigger autocommands; handle those properly.
- Don't change the list entry index in qf_jump_edit_buffer if we fail
due to 'wfb' (achieved by returning FAIL; QF_ABORT should only be used
if the list was changed).
- Make qf_jump_edit_buffer actually switch to prevwin when using `:cXX`
commands **outside** of the list window if 'wfb' is set in curwin.
Handle autocommands properly in case they mess with the list.
NOTE: previously, it seemed to split if 'wfb' was set, but do nothing
and fail if prevwin is *valid*. This behaviour seemed strange, and maybe
unintentional? Now it aligns more with what's described for the `:cXX`
commands in the original PR description when used outside a list window,
I think.
- In both functions, only consider prevwin if 'wfb' isn't set for it;
fallback to splitting otherwise.
- Use win_split to split. Not sure if there was a specific reason for
using ex_splitview. win_split is simpler and respects modifiers like
:vertical that may have been used. Plus, its return value can be checked
for setting opened_window in qf code (technically win_split_ins autocmds
could immediately close it or change windows, in which the qf code might
close some other window on failure; it's already the case elsewhere,
though).
closes: #14142
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 05 Mar 2024 20:45:04 +0100 |
parents | 4027cefc2aab |
children |
line wrap: on
line source
:" Use this script to create the file "bugreport.txt", which contains :" information about the environment of a possible bug in Vim. :" :" Maintainer: The Vim Project <https://github.com/vim/vim> :" Last change: 2023 Aug 10 :" Former Maintainer: Bram Moolenaar <Bram@vim.org> :" :" To use inside Vim: :" :so $VIMRUNTIME/bugreport.vim :" Or, from the command line: :" vim -s $VIMRUNTIME/bugreport.vim :" :" The "if 1" lines are to avoid error messages when expression evaluation is :" not compiled in. :" :if 1 : let more_save = &more :endif :set nomore :if has("unix") : !echo "uname -a" >bugreport.txt : !uname -a >>bugreport.txt :endif :redir >>bugreport.txt :version :if 1 : func <SID>CheckDir(n) : if isdirectory(a:n) : echo 'directory "' . a:n . '" exists' : else : echo 'directory "' . a:n . '" does NOT exist' : endif : endfun : func <SID>CheckFile(n) : if filereadable(a:n) : echo '"' . a:n . '" is readable' : else : echo '"' . a:n . '" is NOT readable' : endif : endfun : echo "--- Directories and Files ---" : echo '$VIM = "' . $VIM . '"' : call <SID>CheckDir($VIM) : echo '$VIMRUNTIME = "' . $VIMRUNTIME . '"' : call <SID>CheckDir($VIMRUNTIME) : call <SID>CheckFile(&helpfile) : call <SID>CheckFile(fnamemodify(&helpfile, ":h") . "/tags") : call <SID>CheckFile($VIMRUNTIME . "/menu.vim") : call <SID>CheckFile($VIMRUNTIME . "/filetype.vim") : call <SID>CheckFile($VIMRUNTIME . "/syntax/synload.vim") : delfun <SID>CheckDir : delfun <SID>CheckFile : echo "--- Scripts sourced ---" : scriptnames :endif :set all :set termcap :au :if 1 : echo "--- Normal/Visual mode mappings ---" :endif :map :if 1 : echo "--- Insert/Command-line mode mappings ---" :endif :map! :if 1 : echo "--- Abbreviations ---" :endif :ab :if 1 : echo "--- Highlighting ---" :endif :highlight :if 1 : echo "--- Variables ---" :endif :if 1 : let :endif :redir END :set more& :if 1 : let &more = more_save : unlet more_save :endif :e bugreport.txt