Mercurial > vim
view src/osdef2.h.in @ 33815:08f9e1eac4cf v9.0.2123
patch 9.0.2123: Problem with initializing the length of range() lists
Commit: https://github.com/vim/vim/commit/df63da98d8dc284b1c76cfe1b17fa0acbd6094d8
Author: Christian Brabandt <cb@256bit.org>
Date: Thu Nov 23 20:14:28 2023 +0100
patch 9.0.2123: Problem with initializing the length of range() lists
Problem: Problem with initializing the length of range() lists
Solution: Set length explicitly when it shouldn't contain any items
range() may cause a wrong calculation of list length, which may later
then cause a segfault in list_find(). This is usually not a problem,
because range_list_materialize() calculates the length, when it
materializes the list.
In addition, in list_find() when the length of the range was wrongly
initialized, it may seem to be valid, so the check for list index
out-of-bounds will not be true, because it is called before the list is
actually materialized. And so we may eventually try to access a null
pointer, causing a segfault.
So this patch does 3 things:
- In f_range(), when we know that the list should be empty, explicitly
set the list->lv_len value to zero. This should happen, when
start is larger than end (in case the stride is positive) or
end is larger than start when the stride is negative.
This should fix the underlying issue properly. However,
- as a safety measure, let's check that the requested index is not
out of range one more time, after the list has been materialized
and return NULL in case it suddenly is.
- add a few more tests to verify the behaviour.
fixes: #13557
closes: #13563
Co-authored-by: Tim Pope <tpope@github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Thu, 23 Nov 2023 20:30:07 +0100 |
| parents | 9f3fd7937957 |
| children |
line wrap: on
line source
/* * osdef2.h.in - See osdef1.h.in for a description. */ extern int remove(const char *); extern int rename(const char *, const char *); extern int free(char *); extern char *malloc(unsigned int); extern char *realloc(char *, int); extern char *getenv(char *); #ifndef __TANDEM extern int setenv(char *, char *, int); #else extern int setenv(const char *, const char *, int); #endif extern int putenv(const char *); #ifndef __TANDEM extern int gethostname(char *, int); #endif extern void perror(char *); #ifndef __TANDEM extern int sleep(int); #endif extern int usleep(unsigned int); extern unsigned int alarm(unsigned int); #ifndef __TANDEM extern int chdir(char *); #endif extern int fchdir(int); #ifndef stat /* could be redefined to stat64() */ extern int stat(const char *, struct stat *); #endif #ifndef lstat /* could be redefined to lstat64() */ extern int lstat(const char *, struct stat *); #endif extern int fstat(int, struct stat *); extern int open(const char *, int, ...); extern int close(int); #ifndef __TANDEM extern int read(int, char *, size_t); extern int write(int, char *, size_t); #endif extern int pipe(int *); extern off_t lseek(int, off_t, int); extern void sync(void); extern uid_t getuid(void); extern gid_t getgid(void); extern void qsort(void *, size_t, size_t, int (*)(const void *, const void *)); extern int isatty(int); extern int getpid(void); extern int dup(int); extern int unlink(const char *); extern int link(const char *, const char *); extern int mkdir(const char *, mode_t); extern int rmdir(const char *); extern int tgetent(char *, char *); extern int tgetnum(char *); extern int tgetflag(char *); extern char *tgoto(char *, int, int); extern int tputs(char *, int, int (*)(int)); #ifdef HAVE_TERMIOS_H struct termios; /* for tcgetattr() */ extern int tcgetattr(int, struct termios *); extern int tcsetattr(int, int, const struct termios *); #endif #ifdef HAVE_SYS_STATFS_H struct statfs; /* for fstatfs() */ extern int fstatfs(int, struct statfs *, int, int); #endif #ifdef HAVE_GETTIMEOFDAY struct timeval; /* for gettimeofday() */ struct timezone; /* for gettimeofday() */ extern int gettimeofday(struct timeval *tp, struct timezone *tzp); extern time_t time(time_t *); #endif #ifdef HAVE_GETPWNAM struct passwd; /* for getpwnam() */ extern struct passwd *getpwnam(const char *); #endif #ifdef USE_TMPNAM extern char *tmpnam(char *); #else extern char *mktemp(char *); #endif #ifdef ISC extern int _Xmblen(char const *, size_t); #else /* This is different from the header but matches mblen() */ extern int _Xmblen(char *, size_t); #endif