Mercurial > vim
view src/nbdebug.c @ 33815:08f9e1eac4cf v9.0.2123
patch 9.0.2123: Problem with initializing the length of range() lists
Commit: https://github.com/vim/vim/commit/df63da98d8dc284b1c76cfe1b17fa0acbd6094d8
Author: Christian Brabandt <cb@256bit.org>
Date: Thu Nov 23 20:14:28 2023 +0100
patch 9.0.2123: Problem with initializing the length of range() lists
Problem: Problem with initializing the length of range() lists
Solution: Set length explicitly when it shouldn't contain any items
range() may cause a wrong calculation of list length, which may later
then cause a segfault in list_find(). This is usually not a problem,
because range_list_materialize() calculates the length, when it
materializes the list.
In addition, in list_find() when the length of the range was wrongly
initialized, it may seem to be valid, so the check for list index
out-of-bounds will not be true, because it is called before the list is
actually materialized. And so we may eventually try to access a null
pointer, causing a segfault.
So this patch does 3 things:
- In f_range(), when we know that the list should be empty, explicitly
set the list->lv_len value to zero. This should happen, when
start is larger than end (in case the stride is positive) or
end is larger than start when the stride is negative.
This should fix the underlying issue properly. However,
- as a safety measure, let's check that the requested index is not
out of range one more time, after the list has been materialized
and return NULL in case it suddenly is.
- add a few more tests to verify the behaviour.
fixes: #13557
closes: #13563
Co-authored-by: Tim Pope <tpope@github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Thu, 23 Nov 2023 20:30:07 +0100 |
parents | 50555279168b |
children |
line wrap: on
line source
/* vi:set ts=8 sw=8 noet: * * VIM - Vi IMproved by Bram Moolenaar * Visual Workshop integration by Gordon Prieur * * Do ":help uganda" in Vim to read copying and usage conditions. * Do ":help credits" in Vim to see a list of people who contributed. * See README.txt for an overview of the Vim source code. */ /* * NetBeans Debugging Tools. What are these tools and why are they important? * There are two main tools here. The first tool is a tool for delaying or * stopping gvim during startup. The second tool is a protocol log tool. * * The startup delay tool is called nbdebug_wait(). This is very important for * debugging startup problems because gvim will be started automatically from * netbeans and cannot be run directly from a debugger. The only way to debug * a gvim started by netbeans is by attaching a debugger to it. Without this * tool all startup code will have completed before you can get the pid and * attach. * * The second tool is a log tool. * * This code must have NBDEBUG defined for it to be compiled into vim/gvim. */ #ifdef NBDEBUG #include "vim.h" FILE *nb_debug = NULL; u_int nb_dlevel = 0; // nb_debug verbosity level void nbdb(char *, ...) ATTRIBUTE_FORMAT_PRINTF(1, 2); static int lookup(char *); #ifdef USE_NB_ERRORHANDLER static int errorHandler(Display *, XErrorEvent *); #endif /* * nbdebug_wait - This function can be used to delay or stop execution of vim. * It's normally used to delay startup while attaching a * debugger to a running process. Since NetBeans starts gvim * from a background process this is the only way to debug * startup problems. */ void nbdebug_wait( u_int wait_flags, // tells what to do char *wait_var, // wait environment variable u_int wait_secs) // how many seconds to wait { init_homedir(); // not inited yet #ifdef USE_WDDUMP WDDump(0, 0, 0); #endif // for debugging purposes only if (wait_flags & WT_ENV && wait_var && getenv(wait_var) != NULL) { sleep(atoi(getenv(wait_var))); } else if (wait_flags & WT_WAIT && lookup("~/.gvimwait")) { sleep(wait_secs > 0 && wait_secs < 120 ? wait_secs : 20); } else if (wait_flags & WT_STOP && lookup("~/.gvimstop")) { int w = 1; while (w) { ; } } } void nbdebug_log_init( char *log_var, // env var with log file char *level_var) // env var with nb_debug level { char *file; // possible nb_debug output file char *cp; // nb_dlevel pointer if (log_var && (file = getenv(log_var)) != NULL) { time_t now; nb_debug = fopen(file, "a"); time(&now); fprintf(nb_debug, "%s", get_ctime(now, TRUE)); if (level_var && (cp = getenv(level_var)) != NULL) { nb_dlevel = strtoul(cp, NULL, 0); } else { nb_dlevel = NB_TRACE; // default level } #ifdef USE_NB_ERRORHANDLER XSetErrorHandler(errorHandler); #endif } } void nbdbg(char *fmt, ...) { va_list ap; if (nb_debug != NULL && nb_dlevel & NB_TRACE) { va_start(ap, fmt); vfprintf(nb_debug, fmt, ap); va_end(ap); fflush(nb_debug); } } static int lookup(char *file) { char buf[BUFSIZ]; expand_env((char_u *) file, (char_u *) buf, BUFSIZ); return #ifndef FEAT_GUI_MSWIN (access(buf, F_OK) == 0); #else (access(buf, 0) == 0); #endif } #ifdef USE_NB_ERRORHANDLER static int errorHandler( Display *dpy, XErrorEvent *err) { char msg[256]; char buf[256]; XGetErrorText(dpy, err->error_code, msg, sizeof(msg)); nbdbg("\n\nNBDEBUG Vim: X Error of failed request: %s\n", msg); sprintf(buf, "%d", err->request_code); XGetErrorDatabaseText(dpy, "XRequest", buf, "Unknown", msg, sizeof(msg)); nbdbg("\tMajor opcode of failed request: %d (%s)\n", err->request_code, msg); if (err->request_code > 128) { nbdbg("\tMinor opcode of failed request: %d\n", err->minor_code); } return 0; } #endif #endif // NBDEBUG