Mercurial > vim
view src/msvc-latest.bat @ 33815:08f9e1eac4cf v9.0.2123
patch 9.0.2123: Problem with initializing the length of range() lists
Commit: https://github.com/vim/vim/commit/df63da98d8dc284b1c76cfe1b17fa0acbd6094d8
Author: Christian Brabandt <cb@256bit.org>
Date: Thu Nov 23 20:14:28 2023 +0100
patch 9.0.2123: Problem with initializing the length of range() lists
Problem: Problem with initializing the length of range() lists
Solution: Set length explicitly when it shouldn't contain any items
range() may cause a wrong calculation of list length, which may later
then cause a segfault in list_find(). This is usually not a problem,
because range_list_materialize() calculates the length, when it
materializes the list.
In addition, in list_find() when the length of the range was wrongly
initialized, it may seem to be valid, so the check for list index
out-of-bounds will not be true, because it is called before the list is
actually materialized. And so we may eventually try to access a null
pointer, causing a segfault.
So this patch does 3 things:
- In f_range(), when we know that the list should be empty, explicitly
set the list->lv_len value to zero. This should happen, when
start is larger than end (in case the stride is positive) or
end is larger than start when the stride is negative.
This should fix the underlying issue properly. However,
- as a safety measure, let's check that the requested index is not
out of range one more time, after the list has been materialized
and return NULL in case it suddenly is.
- add a few more tests to verify the behaviour.
fixes: #13557
closes: #13563
Co-authored-by: Tim Pope <tpope@github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Thu, 23 Nov 2023 20:30:07 +0100 |
parents | 54dda39c5bb3 |
children |
line wrap: on
line source
@echo off rem To be used on MS-Windows for Visual C++ 2017 or later. rem See INSTALLpc.txt for information. rem rem Usage: rem For x86 builds run this with "x86" option: rem msvc-latest x86 rem For x64 builds run this with "x86_amd64" option or "x64" option: rem msvc-latest x86_amd64 rem msvc-latest x64 rem rem Optional environment variables: rem VSWHERE: rem Full path to vswhere.exe. rem VSVEROPT: rem Option to search specific version of Visual Studio. rem Default: -latest rem To search VS2017: rem set "VSVEROPT=-version [15.0^,16.0^)" rem To search VS2019: rem set "VSVEROPT=-version [16.0^,17.0^)" rem To search VS2022: rem set "VSVEROPT=-version [17.0^,18.0^)" if "%VSWHERE%"=="" ( set "VSWHERE=%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere.exe" set VSWHERE_SET=yes ) if not exist "%VSWHERE%" ( echo Error: vswhere not found. set VSWHERE= set VSWHERE_SET= exit /b 1 ) if "%VSVEROPT%"=="" ( set VSVEROPT=-latest set VSVEROPT_SET=yes ) rem Search Visual Studio Community, Professional or above. for /f "usebackq tokens=*" %%i in (`"%VSWHERE%" %VSVEROPT% -products * -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 -property installationPath`) do ( set InstallDir=%%i ) if exist "%InstallDir%\VC\Auxiliary\Build\vcvarsall.bat" ( call "%InstallDir%\VC\Auxiliary\Build\vcvarsall.bat" %* goto done ) rem Search Visual Studio 2017 Express. rem (Visual Studio 2017 Express uses different component IDs.) for /f "usebackq tokens=*" %%i in (`"%VSWHERE%" %VSVEROPT% -products Microsoft.VisualStudio.Product.WDExpress -property installationPath`) do ( set InstallDir=%%i ) if exist "%InstallDir%\VC\Auxiliary\Build\vcvarsall.bat" ( call "%InstallDir%\VC\Auxiliary\Build\vcvarsall.bat" %* ) else ( echo Error: vcvarsall.bat not found. rem Set ERRORLEVEL to 1. call ) :done if "%VSWHERE_SET%"=="yes" ( set VSWHERE= set VSWHERE_SET= ) if "%VSVEROPT_SET%"=="yes" ( set VSVEROPT= set VSVEROPT_SET= ) set InstallDir=