Mercurial > vim
view src/testdir/test_move.vim @ 33664:06b59278bfcf v9.0.2070
patch 9.0.2070: [security] disallow setting env in restricted mode
Commit: https://github.com/vim/vim/commit/6b89dd6a7257a1e2e9c7ea070b407bc4674a5118
Author: Christian Brabandt <cb@256bit.org>
Date: Thu Oct 26 22:14:17 2023 +0200
patch 9.0.2070: [security] disallow setting env in restricted mode
Problem: [security] disallow setting env in restricted mode
Solution: Setting environment variables in restricted mode could
potentially be used to execute shell commands. Disallow this.
restricted mode: disable allow setting of environment variables
Setting environment variables in restricted mode, may have some unwanted
consequences. So, for example by setting $GCONV_PATH in restricted mode
and then calling the iconv() function, one may be able to execute some
unwanted payload, because the `iconv_open()` function internally uses
the `$GCONV_PATH` variable to find its conversion data.
So let's disable setting environment variables, even so this is no
complete protection, since we are not clearing the existing environment.
I tried a few ways but wasn't successful :(
One could also argue to disable the iconv() function completely in
restricted mode, but who knows what other API functions can be
influenced by setting some other unrelated environment variables.
So let's leave it as it is currently.
closes: #13394
See: https://huntr.com/bounties/b0a2eda1-459c-4e36-98e6-0cc7d7faccfe/
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Thu, 26 Oct 2023 22:30:03 +0200 |
parents | 984969b81d63 |
children |
line wrap: on
line source
" Test the ":move" command. source check.vim source screendump.vim func Test_move() enew! call append(0, ['line 1', 'line 2', 'line 3']) g /^$/ delete _ set nomodified move . call assert_equal(['line 1', 'line 2', 'line 3'], getline(1, 3)) call assert_false(&modified) 1,2move 0 call assert_equal(['line 1', 'line 2', 'line 3'], getline(1, 3)) call assert_false(&modified) 1,3move 3 call assert_equal(['line 1', 'line 2', 'line 3'], getline(1, 3)) call assert_false(&modified) 1move 2 call assert_equal(['line 2', 'line 1', 'line 3'], getline(1, 3)) call assert_true(&modified) set nomodified 3move 0 call assert_equal(['line 3', 'line 2', 'line 1'], getline(1, 3)) call assert_true(&modified) set nomodified 2,3move 0 call assert_equal(['line 2', 'line 1', 'line 3'], getline(1, 3)) call assert_true(&modified) set nomodified call assert_fails('1,2move 1', 'E134:') call assert_fails('2,3move 2', 'E134:') call assert_fails("move -100", 'E16:') call assert_fails("move +100", 'E16:') call assert_fails('move', 'E16:') call assert_fails("move 'r", 'E20:') %bwipeout! endfunc func Test_move_undo() CheckRunVimInTerminal let lines =<< trim END call setline(1, ['First', 'Second', 'Third', 'Fourth']) END call writefile(lines, 'Xtest_move_undo.vim', 'D') let buf = RunVimInTerminal('-S Xtest_move_undo.vim', #{rows: 10, cols: 60, statusoff: 2}) call term_sendkeys(buf, "gg:move +1\<CR>") call VerifyScreenDump(buf, 'Test_move_undo_1', {}) " here the display would show the last few lines scrolled down call term_sendkeys(buf, "u") call term_sendkeys(buf, ":\<Esc>") call VerifyScreenDump(buf, 'Test_move_undo_2', {}) call StopVimInTerminal(buf) endfunc " vim: shiftwidth=2 sts=2 expandtab