Mercurial > vim
view src/testdir/test_makeencoding.py @ 33664:06b59278bfcf v9.0.2070
patch 9.0.2070: [security] disallow setting env in restricted mode
Commit: https://github.com/vim/vim/commit/6b89dd6a7257a1e2e9c7ea070b407bc4674a5118
Author: Christian Brabandt <cb@256bit.org>
Date: Thu Oct 26 22:14:17 2023 +0200
patch 9.0.2070: [security] disallow setting env in restricted mode
Problem: [security] disallow setting env in restricted mode
Solution: Setting environment variables in restricted mode could
potentially be used to execute shell commands. Disallow this.
restricted mode: disable allow setting of environment variables
Setting environment variables in restricted mode, may have some unwanted
consequences. So, for example by setting $GCONV_PATH in restricted mode
and then calling the iconv() function, one may be able to execute some
unwanted payload, because the `iconv_open()` function internally uses
the `$GCONV_PATH` variable to find its conversion data.
So let's disable setting environment variables, even so this is no
complete protection, since we are not clearing the existing environment.
I tried a few ways but wasn't successful :(
One could also argue to disable the iconv() function completely in
restricted mode, but who knows what other API functions can be
influenced by setting some other unrelated environment variables.
So let's leave it as it is currently.
closes: #13394
See: https://huntr.com/bounties/b0a2eda1-459c-4e36-98e6-0cc7d7faccfe/
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Thu, 26 Oct 2023 22:30:03 +0200 |
parents | e71d3bdf3bc3 |
children |
line wrap: on
line source
#!/usr/bin/python # -*- coding: utf-8 -*- # Test program for :make, :grep and :cgetfile. from __future__ import print_function, unicode_literals import locale import io import sys def set_output_encoding(enc=None): """Set the encoding of stdout and stderr arguments: enc -- Encoding name. If omitted, locale.getpreferredencoding() is used. """ if enc is None: enc = locale.getpreferredencoding() def get_text_writer(fo, **kwargs): kw = dict(kwargs) kw.setdefault('errors', 'backslashreplace') # use \uXXXX style kw.setdefault('closefd', False) if sys.version_info[0] < 3: # Work around for Python 2.x # New line conversion isn't needed here. Done in somewhere else. writer = io.open(fo.fileno(), mode='w', newline='', **kw) write = writer.write # save the original write() function enc = locale.getpreferredencoding() def convwrite(s): if isinstance(s, bytes): write(s.decode(enc)) # convert to unistr else: write(s) try: writer.flush() # needed on Windows except IOError: pass writer.write = convwrite else: writer = io.open(fo.fileno(), mode='w', **kw) return writer sys.stdout = get_text_writer(sys.stdout, encoding=enc) sys.stderr = get_text_writer(sys.stderr, encoding=enc) def main(): enc = 'utf-8' if len(sys.argv) > 1: enc = sys.argv[1] set_output_encoding(enc) message_tbl = { 'utf-8': 'ÀÈÌÒÙ こんにちは 你好', 'latin1': 'ÀÈÌÒÙ', 'cp932': 'こんにちは', 'cp936': '你好', } print('Xfoobar.c(10) : %s (%s)' % (message_tbl[enc], enc)) if __name__ == "__main__": main()