Mercurial > vim
view src/testdir/test_exit.vim @ 33664:06b59278bfcf v9.0.2070
patch 9.0.2070: [security] disallow setting env in restricted mode
Commit: https://github.com/vim/vim/commit/6b89dd6a7257a1e2e9c7ea070b407bc4674a5118
Author: Christian Brabandt <cb@256bit.org>
Date: Thu Oct 26 22:14:17 2023 +0200
patch 9.0.2070: [security] disallow setting env in restricted mode
Problem: [security] disallow setting env in restricted mode
Solution: Setting environment variables in restricted mode could
potentially be used to execute shell commands. Disallow this.
restricted mode: disable allow setting of environment variables
Setting environment variables in restricted mode, may have some unwanted
consequences. So, for example by setting $GCONV_PATH in restricted mode
and then calling the iconv() function, one may be able to execute some
unwanted payload, because the `iconv_open()` function internally uses
the `$GCONV_PATH` variable to find its conversion data.
So let's disable setting environment variables, even so this is no
complete protection, since we are not clearing the existing environment.
I tried a few ways but wasn't successful :(
One could also argue to disable the iconv() function completely in
restricted mode, but who knows what other API functions can be
influenced by setting some other unrelated environment variables.
So let's leave it as it is currently.
closes: #13394
See: https://huntr.com/bounties/b0a2eda1-459c-4e36-98e6-0cc7d7faccfe/
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Thu, 26 Oct 2023 22:30:03 +0200 |
parents | 695b50472e85 |
children |
line wrap: on
line source
" Tests for exiting Vim. source shared.vim source check.vim func Test_exiting() let after =<< trim [CODE] au QuitPre * call writefile(["QuitPre"], "Xtestout") au ExitPre * call writefile(["ExitPre"], "Xtestout", "a") quit [CODE] if RunVim([], after, '') call assert_equal(['QuitPre', 'ExitPre'], readfile('Xtestout')) endif call delete('Xtestout') let after =<< trim [CODE] au QuitPre * call writefile(["QuitPre"], "Xtestout") au ExitPre * call writefile(["ExitPre"], "Xtestout", "a") help wincmd w quit [CODE] if RunVim([], after, '') call assert_equal(['QuitPre', 'ExitPre'], readfile('Xtestout')) endif call delete('Xtestout') let after =<< trim [CODE] au QuitPre * call writefile(["QuitPre"], "Xtestout") au ExitPre * call writefile(["ExitPre"], "Xtestout", "a") split new qall [CODE] if RunVim([], after, '') call assert_equal(['QuitPre', 'ExitPre'], readfile('Xtestout')) endif call delete('Xtestout') " ExitPre autocommand splits the window, so that it's no longer the last one. let after =<< trim [CODE] au QuitPre * call writefile(["QuitPre"], "Xtestout", "a") au ExitPre * call writefile(["ExitPre"], "Xtestout", "a") augroup nasty au ExitPre * split augroup END quit augroup nasty au! ExitPre augroup END quit [CODE] if RunVim([], after, '') call assert_equal(['QuitPre', 'ExitPre', 'QuitPre', 'ExitPre'], \ readfile('Xtestout')) endif call delete('Xtestout') " ExitPre autocommand splits and closes the window, so that there is still " one window but it's a different one. let after =<< trim [CODE] au QuitPre * call writefile(["QuitPre"], "Xtestout", "a") au ExitPre * call writefile(["ExitPre"], "Xtestout", "a") augroup nasty au ExitPre * split | only augroup END quit augroup nasty au! ExitPre augroup END quit [CODE] if RunVim([], after, '') call assert_equal(['QuitPre', 'ExitPre', 'QuitPre', 'ExitPre'], \ readfile('Xtestout')) endif call delete('Xtestout') " ExitPre autocommand also executed on :wqall let after =<< trim [CODE] au QuitPre * call writefile(["QuitPre"], "Xtestout", "a") au ExitPre * call writefile(["ExitPre"], "Xtestout", "a") wqall [CODE] if RunVim([], after, '') call assert_equal(['QuitPre', 'ExitPre'], readfile('Xtestout')) endif call delete('Xtestout') endfunc " Test for getting the Vim exit code from v:exiting func Test_exit_code() call assert_equal(v:null, v:exiting) let before =<< trim [CODE] au QuitPre * call writefile(['qp = ' .. v:exiting], 'Xtestout', 'a') au ExitPre * call writefile(['ep = ' .. v:exiting], 'Xtestout', 'a') au VimLeavePre * call writefile(['lp = ' .. v:exiting], 'Xtestout', 'a') au VimLeave * call writefile(['l = ' .. v:exiting], 'Xtestout', 'a') [CODE] if RunVim(before, ['quit'], '') call assert_equal(['qp = v:null', 'ep = v:null', 'lp = 0', 'l = 0'], readfile('Xtestout')) endif call delete('Xtestout') if RunVim(before, ['cquit'], '') call assert_equal(['lp = 1', 'l = 1'], readfile('Xtestout')) endif call delete('Xtestout') if RunVim(before, ['cquit 4'], '') call assert_equal(['lp = 4', 'l = 4'], readfile('Xtestout')) endif call delete('Xtestout') endfunc func Test_exit_error_reading_input() CheckNotGui CheckNotMSWindows " The early exit causes memory not to be freed somehow CheckNotAsan CheckNotValgrind call writefile([":au VimLeave * call writefile(['l = ' .. v:exiting], 'Xtestout')", ":tabnew", "q:"], 'Xscript', 'bD') if RunVim([], [], '<Xscript') call assert_equal(1, v:shell_error) call assert_equal(['l = 1'], readfile('Xtestout')) endif call delete('Xtestout') endfun " vim: shiftwidth=2 sts=2 expandtab