Mercurial > vim
view src/create_nvcmdidxs.vim @ 33664:06b59278bfcf v9.0.2070
patch 9.0.2070: [security] disallow setting env in restricted mode
Commit: https://github.com/vim/vim/commit/6b89dd6a7257a1e2e9c7ea070b407bc4674a5118
Author: Christian Brabandt <cb@256bit.org>
Date: Thu Oct 26 22:14:17 2023 +0200
patch 9.0.2070: [security] disallow setting env in restricted mode
Problem: [security] disallow setting env in restricted mode
Solution: Setting environment variables in restricted mode could
potentially be used to execute shell commands. Disallow this.
restricted mode: disable allow setting of environment variables
Setting environment variables in restricted mode, may have some unwanted
consequences. So, for example by setting $GCONV_PATH in restricted mode
and then calling the iconv() function, one may be able to execute some
unwanted payload, because the `iconv_open()` function internally uses
the `$GCONV_PATH` variable to find its conversion data.
So let's disable setting environment variables, even so this is no
complete protection, since we are not clearing the existing environment.
I tried a few ways but wasn't successful :(
One could also argue to disable the iconv() function completely in
restricted mode, but who knows what other API functions can be
influenced by setting some other unrelated environment variables.
So let's leave it as it is currently.
closes: #13394
See: https://huntr.com/bounties/b0a2eda1-459c-4e36-98e6-0cc7d7faccfe/
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Thu, 26 Oct 2023 22:30:03 +0200 |
parents | ee1019e59bef |
children |
line wrap: on
line source
" This script generates the table nv_cmd_idx[] which contains the index in " nv_cmds[] table (normal.c) for each of the command character supported in " normal/visual mode. " This is used to speed up the command lookup in nv_cmds[]. " " Script should be run using "make nvcmdidxs", every time the nv_cmds[] table " in src/nv_cmds.h changes. " " This is written in legacy Vim script so that it can be run by a slightly " older Vim version. " Generate the table of normal/visual mode command characters and their " corresponding index. let cmd = 'create_nvcmdidxs' if has('unix') let cmd = './' .. cmd endif let nv_cmdtbl = systemlist(cmd)->map({i, ch -> {'idx': i, 'cmdchar': ch}}) " sort the table by the command character call sort(nv_cmdtbl, {a, b -> a.cmdchar - b.cmdchar}) " Compute the highest index upto which the command character can be directly " used as an index. let nv_max_linear = 0 for i in range(nv_cmdtbl->len()) if i != nv_cmdtbl[i].cmdchar let nv_max_linear = i - 1 break endif endfor " Generate a header file with the table let output =<< trim END /* * Automatically generated code by the create_nvcmdidxs.vim script. * * Table giving the index in nv_cmds[] to lookup based on * the command character. */ // nv_cmd_idx[<normal mode command character>] => nv_cmds[] index static const unsigned short nv_cmd_idx[] = { END " Add each command character in comment and the corresponding index let output += nv_cmdtbl->map({_, v -> \ printf(' /* %5d */ %3d,', v.cmdchar, v.idx)}) let output += ['};', '', \ '// The highest index for which', \ '// nv_cmds[idx].cmd_char == nv_cmd_idx[nv_cmds[idx].cmd_char]'] let output += ['static const int nv_max_linear = ' .. nv_max_linear .. ';'] call writefile(output, "nv_cmdidxs.h") quit " vim: shiftwidth=2 sts=2 expandtab