Mercurial > vim
view src/Make_cyg.mak @ 33664:06b59278bfcf v9.0.2070
patch 9.0.2070: [security] disallow setting env in restricted mode
Commit: https://github.com/vim/vim/commit/6b89dd6a7257a1e2e9c7ea070b407bc4674a5118
Author: Christian Brabandt <cb@256bit.org>
Date: Thu Oct 26 22:14:17 2023 +0200
patch 9.0.2070: [security] disallow setting env in restricted mode
Problem: [security] disallow setting env in restricted mode
Solution: Setting environment variables in restricted mode could
potentially be used to execute shell commands. Disallow this.
restricted mode: disable allow setting of environment variables
Setting environment variables in restricted mode, may have some unwanted
consequences. So, for example by setting $GCONV_PATH in restricted mode
and then calling the iconv() function, one may be able to execute some
unwanted payload, because the `iconv_open()` function internally uses
the `$GCONV_PATH` variable to find its conversion data.
So let's disable setting environment variables, even so this is no
complete protection, since we are not clearing the existing environment.
I tried a few ways but wasn't successful :(
One could also argue to disable the iconv() function completely in
restricted mode, but who knows what other API functions can be
influenced by setting some other unrelated environment variables.
So let's leave it as it is currently.
closes: #13394
See: https://huntr.com/bounties/b0a2eda1-459c-4e36-98e6-0cc7d7faccfe/
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Thu, 26 Oct 2023 22:30:03 +0200 |
parents | b0e19f135e50 |
children |
line wrap: on
line source
# # Makefile for VIM on Win32, using MinGW cross compiler on Cygwin # # Also read INSTALLpc.txt! # # This compiles Vim as a Windows application. If you want Vim to run as a # Cygwin application use the Makefile (just like on Unix). # # The old Make_cyg.mak (maintained by Dan Sharp et al.) was merged into # Make_cyg_ming.mak. Note: USEDLL option was removed. # This file contains Cygwin specific settings. Common settings are contained # in Make_cyg_ming.mak. # # Last updated by Ken Takata. # Last Change: 2014 Oct 21 # uncomment 'PERL' if you want a perl-enabled version #PERL=/cygdrive/c/perl # uncomment 'LUA' if you want a Lua-enabled version #LUA=/cygdrive/c/lua # uncomment 'MZSCHEME' if you want a MzScheme-enabled version #MZSCHEME=/cygdrive/d/plt # uncomment 'PYTHON' if you want a python-enabled version #PYTHON=/cygdrive/c/python20 # uncomment 'PYTHON3' if you want a python3-enabled version #PYTHON3=/cygdrive/c/python31 # uncomment 'TCL' if you want a Tcl-enabled version #TCL=/cygdrive/c/tcl # uncomment 'RUBY' if you want a Ruby-enabled version #RUBY=/cygdribe/c/ruby # Use MinGW-w64 cross compiler. # There are two MinGW-w64 packages in Cygwin: # 32-bit: mingw64-i686-gcc-g++ # 64-bit: mingw64-x86_64-gcc-g++ # You may also need to set 'ARCH' in Make_cyg_ming.mak. CROSS_COMPILE = i686-w64-mingw32- #CROSS_COMPILE = x86_64-w64-mingw32- # Do not change this. UNDER_CYGWIN = yes include Make_cyg_ming.mak # vim: set noet sw=8 ts=8 sts=0 wm=0 tw=0: