Mercurial > vim
diff src/popupwin.c @ 17075:dacd46fbaa90 v8.1.1537
patch 8.1.1537: using "tab" for popup window can be confusing
commit https://github.com/vim/vim/commit/fc06cbbf8601a453b4a62a17558821add09f863f
Author: Bram Moolenaar <Bram@vim.org>
Date: Sat Jun 15 14:14:31 2019 +0200
patch 8.1.1537: using "tab" for popup window can be confusing
Problem: Using "tab" for popup window can be confusing.
Solution: Use "tabpage". (Hirohito Higashi, closes https://github.com/vim/vim/issues/4532)
| author | Bram Moolenaar <Bram@vim.org> |
|---|---|
| date | Sat, 15 Jun 2019 14:15:06 +0200 |
| parents | 294b409ce7e3 |
| children | 2546930657a9 |
line wrap: on
line diff
--- a/src/popupwin.c +++ b/src/popupwin.c @@ -748,8 +748,8 @@ popup_create(typval_T *argvars, typval_T // Avoid that 'buftype' is reset when this buffer is entered. buf->b_p_initialized = TRUE; - if (dict_find(d, (char_u *)"tab", -1) != NULL) - nr = (int)dict_get_number(d, (char_u *)"tab"); + if (dict_find(d, (char_u *)"tabpage", -1) != NULL) + nr = (int)dict_get_number(d, (char_u *)"tabpage"); else if (type == TYPE_NOTIFICATION) nr = -1; // notifications are global by default else @@ -757,7 +757,7 @@ popup_create(typval_T *argvars, typval_T if (nr == 0) { - // popup on current tab + // popup on current tab page wp->w_next = curtab->tp_first_popupwin; curtab->tp_first_popupwin = wp; } @@ -1228,7 +1228,7 @@ not_in_popup_window() /* * Reset all the POPF_HANDLED flags in global popup windows and popup windows - * in the current tab. + * in the current tab page. */ void popup_reset_handled()