patch 9.1.0068: Visual highlighting can still be improved Commit: https://github.com/vim/vim/commit/59bafc8171b08cf326ed40ccb4ee917f9643290e Author: Maxim Kim <habamax@gmail.com> Date: Thu Feb 1 21:07:51 2024 +0100 patch 9.1.0068: Visual highlighting can still be improved Problem: Visual highlighting can still be improved Solution: Update Visual highlighting for 8 color terminals, use uniform grey highlighting for dark and light bg (Maxim Kim) Update terminal Visual 1. Use `ctermbg=Grey ctermfg=Black` for both dark and light This uniforms Visual highlighting between default dark and light colors And should work for vim usually detecting light background for terminals with black/dark background colors. Previously used `ctermfg=White` leaks `cterm=bold` if available colors are less than 16. 2. Use `term=reverse cterm=reverse ctermbg=NONE ctermfg=NONE` for terminals reporting less than 8 colors available If the terminal has less than 8 colors, grey just doesn't work right closes: #13940 Signed-off-by: Maxim Kim <habamax@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>

--- a/src/testdir/dumps/Test_cursorline_with_visualmode_01.dump
+++ b/src/testdir/dumps/Test_cursorline_with_visualmode_01.dump
@@ -1,9 +1,9 @@
-|a+0#ffffff16#6c6c6c255|b|c| | +0#0000000#ffffff0@70
-|a+0#ffffff16#6c6c6c255|b|c| | +0#0000000#ffffff0@70
-|a+0#ffffff16#6c6c6c255|b|c| | +0#0000000#ffffff0@70
-|a+0#ffffff16#6c6c6c255|b|c| | +0#0000000#ffffff0@70
-|a+0#ffffff16#6c6c6c255|b|c| | +0#0000000#ffffff0@70
->a|b+0#ffffff16#6c6c6c255|c| | +0#0000000#ffffff0@70
+|a+0#0000001#a8a8a8255|b|c| | +0#0000000#ffffff0@70
+|a+0#0000001#a8a8a8255|b|c| | +0#0000000#ffffff0@70
+|a+0#0000001#a8a8a8255|b|c| | +0#0000000#ffffff0@70
+|a+0#0000001#a8a8a8255|b|c| | +0#0000000#ffffff0@70
+|a+0#0000001#a8a8a8255|b|c| | +0#0000000#ffffff0@70
+>a|b+0#0000001#a8a8a8255|c| | +0#0000000#ffffff0@70
 |a|b|c| @71
 |a|b|c| @71
 |a|b|c| @71