diff src/terminal.c @ 22864:b825d8ec9a76 v8.2.1979

patch 8.2.1979: "term_opencmd" option of term_start() is truncated Commit: https://github.com/vim/vim/commit/47c5ea44b975adca00eaacecee5c4108996178d9 Author: Bram Moolenaar <Bram@vim.org> Date: Thu Nov 12 15:12:15 2020 +0100 patch 8.2.1979: "term_opencmd" option of term_start() is truncated Problem: "term_opencmd" option of term_start() is truncated. (Sergey Vlasov) Solution: Allocate the buffer to hold the command. (closes #7284)
author Bram Moolenaar <Bram@vim.org>
date Thu, 12 Nov 2020 15:15:04 +0100
parents 6d50182e7e24
children b952e0a3af2f
line wrap: on
line diff
--- a/src/terminal.c
+++ b/src/terminal.c
@@ -3450,15 +3450,19 @@ term_after_channel_closed(term_T *term)
 	if (term->tl_finish == TL_FINISH_OPEN
 				   && term->tl_buffer->b_nwindows == 0)
 	{
-	    char buf[50];
-
-	    // TODO: use term_opencmd
-	    ch_log(NULL, "terminal job finished, opening window");
-	    vim_snprintf(buf, sizeof(buf),
-		    term->tl_opencmd == NULL
-			    ? "botright sbuf %d"
-			    : (char *)term->tl_opencmd, fnum);
-	    do_cmdline_cmd((char_u *)buf);
+	    char    *cmd = term->tl_opencmd == NULL
+				? "botright sbuf %d"
+				: (char *)term->tl_opencmd;
+	    size_t  len = strlen(cmd) + 50;
+	    char    *buf = alloc(len);
+
+	    if (buf != NULL)
+	    {
+		ch_log(NULL, "terminal job finished, opening window");
+		vim_snprintf(buf, len, cmd, fnum);
+		do_cmdline_cmd((char_u *)buf);
+		vim_free(buf);
+	    }
 	}
 	else
 	    ch_log(NULL, "terminal job finished");