Mercurial > vim
diff src/vim9compile.c @ 33173:9efd99a717c1 v9.0.1867
patch 9.0.1867: Vim9: access to interface statics possible
Commit: https://github.com/vim/vim/commit/18143d3111b2122c7a94ca51085a60b3073cb139
Author: Ernie Rael <errael@raelity.com>
Date: Mon Sep 4 22:30:41 2023 +0200
patch 9.0.1867: Vim9: access to interface statics possible
Problem: Vim9: access to interface statics possible
Solution: Prevent direct access to interface statics
closes: #13007
Signed-off-by: Christian Brabandt <cb@256bit.org>
Co-authored-by: Ernie Rael <errael@raelity.com>
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Mon, 04 Sep 2023 22:45:04 +0200 |
| parents | bede81965821 |
| children | 108d890d887f |
line wrap: on
line diff
--- a/src/vim9compile.c +++ b/src/vim9compile.c @@ -1874,7 +1874,13 @@ compile_lhs( &lhs->lhs_member_idx, &m); if (lhs->lhs_member_idx < 0) return FAIL; - + if ((cl->class_flags & CLASS_INTERFACE) != 0 + && lhs->lhs_type->tt_type == VAR_CLASS) + { + semsg(_(e_interface_static_direct_access_str), + cl->class_name, m->ocm_name); + return FAIL; + } // If it is private member variable, then accessing it outside the // class is not allowed. if ((m->ocm_access != VIM_ACCESS_ALL) && !inside_class(cctx, cl)) @@ -2112,8 +2118,9 @@ compile_load_lhs_with_index(lhs_T *lhs, return FAIL; } if (cl->class_flags & CLASS_INTERFACE) - return generate_GET_ITF_MEMBER(cctx, cl, lhs->lhs_member_idx, type); - return generate_GET_OBJ_MEMBER(cctx, lhs->lhs_member_idx, type); + return generate_GET_ITF_MEMBER(cctx, cl, lhs->lhs_member_idx, type, + FALSE); + return generate_GET_OBJ_MEMBER(cctx, lhs->lhs_member_idx, type, FALSE); } compile_load_lhs(lhs, var_start, NULL, cctx);